Issue 23033022: pdfviewer: when q start, and an operator is called, it should not be able to see operands before q.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23033022: pdfviewer: when q start, and an operator is called, it should not be able to see operands before q.… (Closed)

Created:
7 years, 4 months ago by edisonn

Modified:
7 years, 4 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pdfviewer: when q start, and an operator is called, it should not be able to see operands before q. nest/unnest are similar with pop/push - simulates a stack of stacks, in a single stack Committed: https://code.google.com/p/skia/source/detail?r=10873

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -11 lines)			Patch
M	experimental/PdfViewer/SkPdfFont.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	experimental/PdfViewer/SkPdfGraphicsState.h	View	5 chunks	+41 lines, -6 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfRenderer.cpp	View	2 chunks	+19 lines, -3 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.cpp	View	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

edisonn

7 years, 4 months ago (2013-08-22 15:37:28 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r10873 (presubmit successful).

Expand Messages | Collapse Messages