Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2303293004: Revert of Remove unneeded split_count assignments (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index d1d73cb597175ca0ca12ecac085fda7e943ff797..b6d7dcb7654cd2577d8f5ba5493204e3654380f3 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -42,6 +42,16 @@
]
if (is_android && use_openmax_dl_fft) {
include_dirs += [ "//third_party/openmax_dl" ]
+ }
+}
+
+if (!is_component_build) {
+ if (is_win && is_official_build) {
+ # Shard this target into parts to work around linker limitations
+ # on link time code generation builds.
+ split_count = 5
+ } else {
+ split_count = 1
}
}
@@ -170,18 +180,11 @@
}
target(core_link_large_target_type, "remaining") {
- if (core_link_large_target_type == "split_static_library") {
+ if (is_win && is_official_build &&
+ core_link_large_target_type == "split_static_library") {
# Shard this target into parts to work around linker limitations
# on link time code generation builds.
- if (is_win) {
- if (is_official_build) {
- split_count = 19
- } else {
- split_count = 5
- }
- } else {
- split_count = 1
- }
+ split_count = 19
}
# This is currently a mashup of "webcore_rendering" and "webcore_remaining"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698