Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2303273003: DevTools: Bump node.js version for buildbot (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Bump node.js version for buildbot I uploaded the latest LTS node.js version to a google storage bucket and updated the buildbot/node.py script. Hopefully since this is LTS, we won't need to bump this node version too often. BUG=642046 Committed: https://crrev.com/7c16a24066b7ea861e6f2b562b19565ddd6cb059 Cr-Commit-Position: refs/heads/master@{#416396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/scripts/buildbot/node.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chenwilliam
PTAL.
4 years, 3 months ago (2016-09-02 22:18:57 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-09-02 22:22:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303273003/1
4 years, 3 months ago (2016-09-02 22:27:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 23:50:07 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:53:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c16a24066b7ea861e6f2b562b19565ddd6cb059
Cr-Commit-Position: refs/heads/master@{#416396}

Powered by Google App Engine
This is Rietveld 408576698