Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2303263003: blimp: Fix for multiple show IME messages (Closed)

Created:
4 years, 3 months ago by shaktisahu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Fix for multiple show IME messages Some websites trigger multiple Show IME messages for the same textbox which generates multiple popups superimposed one over another. This CL avoids creating multiple popups. BUG=611111 Committed: https://crrev.com/1677c09d3a29f04fc873b9c0d3188f72eb22e16d Cr-Commit-Position: refs/heads/master@{#416860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeHelperDialog.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shaktisahu
4 years, 3 months ago (2016-09-02 19:36:06 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 3 months ago (2016-09-07 05:11:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303263003/1
4 years, 3 months ago (2016-09-07 05:33:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 06:16:06 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 06:17:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1677c09d3a29f04fc873b9c0d3188f72eb22e16d
Cr-Commit-Position: refs/heads/master@{#416860}

Powered by Google App Engine
This is Rietveld 408576698