Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2303263002: Update status for chrome 53 on linux (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for chrome 53 on linux BUG= Committed: https://github.com/dart-lang/sdk/commit/b39fa1d58d80c0bc5f3d05b25d743233032dc74b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M tests/co19/co19-dart2js.status View 15 chunks +31 lines, -34 lines 2 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
TBR=eernst@google
4 years, 3 months ago (2016-09-02 12:08:12 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as b39fa1d58d80c0bc5f3d05b25d743233032dc74b (presubmit successful).
4 years, 3 months ago (2016-09-02 12:08:49 UTC) #4
eernst
4 years, 3 months ago (2016-09-02 14:48:49 UTC) #5
Message was sent while issue was closed.
LGTM.

Looking into the big picture, I interpret this as the following kind of CL:

The section `[ $compiler == dart2js && $runtime == safari ]` has been
reorganized (lines only reordered, not changed), such that multiple lines for
the same test are now adjacent. Moreover, the tiny sections requiring
`$fast_startup` have been deleted (presumably `$fast_startup` never happens any
more).

With that in mind, the comments I wrote at first are irrelevant (they are
concerned with surprising properties of the lines that were moved around, but
those lines should be OK already because of some other review). I left them in
anyway, just in case it is relevant.

https://codereview.chromium.org/2303263002/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/2303263002/diff/1/tests/co19/co19-dart2js.sta...
tests/co19/co19-dart2js.status:3480:
+LayoutTests/fast/canvas/webgl/context-lost_t01: Skip
Is it possible to make the status more informative than `Skip`?

https://codereview.chromium.org/2303263002/diff/1/tests/co19/co19-dart2js.sta...
tests/co19/co19-dart2js.status:3487:
+LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565_t01:
Skip
What is the purpose of having 2 status lines about a single test?
Does the `Skip` overrule the `RuntimeError, Timeout`?

Similar issues arise for tests with names ending in rgba5551_t01,
video_t01, inline_t01, priority_t01, text_t01, sequence_t01,
ligatures_t01, any_t01, insertion_t01, selectorText_t01,
scrollbar_t01, and several others.

Powered by Google App Engine
This is Rietveld 408576698