Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2303233002: [gn] Switch windows to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch windows to gn BUG=chromium:474921 Committed: https://crrev.com/25603e0b262773f12f0929872e5ca902dfe622cf Cr-Commit-Position: refs/heads/master@{#39128}

Patch Set 1 #

Patch Set 2 : [gn] Switch windows to gn #

Patch Set 3 : Docu #

Patch Set 4 : Revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M infra/mb/mb_config.pyl View 1 7 chunks +18 lines, -26 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Michael Achenbach
PTAL. Online flag comparison was only possible in an experiment: https://codereview.chromium.org/2155623003/ Differences are shown here ...
4 years, 3 months ago (2016-09-02 09:46:30 UTC) #5
jochen (gone - plz use gerrit)
so we end up calling ia32 x86 now?
4 years, 3 months ago (2016-09-02 09:53:36 UTC) #6
Michael Achenbach
Meh ignore pathset 3, will revert that back...
4 years, 3 months ago (2016-09-02 09:53:48 UTC) #7
Michael Achenbach
ok - patch 4 is ready, but I'll work on a test error in nosnap ...
4 years, 3 months ago (2016-09-02 09:55:52 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-02 09:58:04 UTC) #9
Michael Achenbach
On 2016/09/02 09:53:36, jochen wrote: > so we end up calling ia32 x86 now? At ...
4 years, 3 months ago (2016-09-02 10:05:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303233002/60001
4 years, 3 months ago (2016-09-02 10:41:00 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 11:02:23 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:02:32 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/25603e0b262773f12f0929872e5ca902dfe622cf
Cr-Commit-Position: refs/heads/master@{#39128}

Powered by Google App Engine
This is Rietveld 408576698