Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2303213003: RESOLVED_UNIT2 and RESOLVED_UNIT3 can be reused. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

RESOLVED_UNIT2 and RESOLVED_UNIT3 can be reused. With incremental invalidation directives don't change, so we can reuse these results too. So, it is worth to keep some number of them in the cache. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9512e3f88c2ffa78efb9e24aa33dbcb683e2e21a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scheglov
4 years, 3 months ago (2016-09-02 18:28:05 UTC) #1
Brian Wilkerson
nice! lgtm
4 years, 3 months ago (2016-09-02 19:41:39 UTC) #3
scheglov
4 years, 3 months ago (2016-09-02 19:46:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9512e3f88c2ffa78efb9e24aa33dbcb683e2e21a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698