Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2303093003: MD Settings: Internet: Enable SIM unlock with no cellular network (Closed)
Patch Set: Rebase plus Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index f6f4a425841d90868469c5eff4b8b8aa0031dadf..90f58da001864f6f6577883b921e4f8f9bb38fe8 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -404,6 +404,9 @@ Polymer({
/** @private */
onForgetTap_: function() {
this.networkingPrivate.forgetNetwork(this.guid);
+ // A forgotten WiFi network can still be configured, but not other types.
+ if (this.networkProperties.Type != CrOnc.Type.WI_FI)
+ this.close_();
},
/** @private */
@@ -678,8 +681,9 @@ Polymer({
* @return {boolean}
* @private
*/
- hasAdvancedOrDeviceFields_: function() {
- return this.hasAdvancedFields_() || this.hasDeviceFields_();
+ showAdvanced_: function() {
+ return this.hasAdvancedFields_() || this.hasDeviceFields_() ||
+ this.isRememberedOrConnected_();
},
/**

Powered by Google App Engine
This is Rietveld 408576698