chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2303093003: MD Settings: Internet: Enable SIM unlock with no cellular network

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2303093003: MD Settings: Internet: Enable SIM unlock with no cellular network (Closed)

Patch Set: No settings_vars_css cleanup Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.html ('k') | chrome/browser/resources/settings/internet_page/internet_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index f6f4a425841d90868469c5eff4b8b8aa0031dadf..90f58da001864f6f6577883b921e4f8f9bb38fe8 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -404,6 +404,9 @@ Polymer({

/** @private */

onForgetTap_: function() {

this.networkingPrivate.forgetNetwork(this.guid);

+ // A forgotten WiFi network can still be configured, but not other types.

+ if (this.networkProperties.Type != CrOnc.Type.WI_FI)

+ this.close_();

/** @private */

@@ -678,8 +681,9 @@ Polymer({

* @return {boolean}

* @private

- hasAdvancedOrDeviceFields_: function() {

- return this.hasAdvancedFields_() || this.hasDeviceFields_();

+ showAdvanced_: function() {

+ return this.hasAdvancedFields_() || this.hasDeviceFields_() ||

+ this.isRememberedOrConnected_();

/**