record drawfilters

record drawfilters

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303033002

Committed: https://skia.googlesource.com/skia/+/6ae6969434302da86de1169545939461ac7147b9

[reed1, 2016-09-01 21:23:20]

Description was changed from

==========
record drawfilters

BUG=skia:
==========

to

==========
record drawfilters

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303033002
==========

[reed1, 2016-09-01 21:23:47]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 21:23:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 21:26:45]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[reed1, 2016-09-01 21:29:46]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 21:29:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:33:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 21:33:09]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[reed1, 2016-09-02 01:13:39]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:13:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 02:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 02:03:21]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-02 09:42:39]

reed@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[reed1, 2016-09-02 09:44:05]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-09-02 09:44:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:44:11]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-09-02 15:44 UTC

[mtklein, 2016-09-02 11:55:21]

lgtm

[commit-bot: I haz the power, 2016-09-02 11:56:55]

Description was changed from

==========
record drawfilters

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303033002
==========

to

==========
record drawfilters

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303033002

Committed:
https://skia.googlesource.com/skia/+/6ae6969434302da86de1169545939461ac7147b9
==========

[commit-bot: I haz the power, 2016-09-02 11:56:56]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6ae6969434302da86de1169545939461ac7147b9

[reed1, 2016-09-02 12:26:37]

Thinking more about this, I would advocate to make this CL temporary, and that
we should consider performing the filter in the SkiaCanvas : this is the same
amount of work -- but only happens once, not on every replay, plus it places the
complexity in the one caller who wants it (i.e. we can then eliminate it from
SkCanvas etc.)