Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230303002: Revert of [Oilpan]: Moving the FontSelector/FontCacheClient, CSSSegmentedFontFace, and FontFaceCache to the o… (Closed)

Created:
6 years, 8 months ago by wibling-chromium
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, sof, eae+blinkwatch, ed+blinkwatch_opera.com, jbroman, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Stephen Chennney, rune+blink, pdr., Inactive, rwlbuis
Visibility:
Public.

Description

Revert of [Oilpan]: Moving the FontSelector/FontCacheClient, CSSSegmentedFontFace, and FontFaceCache to the o… (https://codereview.chromium.org/227083006/) Reason for revert: Broke the build... Original issue's description: > [Oilpan]: Moving the FontSelector/FontCacheClient, CSSSegmentedFontFace, and FontFaceCache to the oilpan heap. > > Had to add two tests to the OilpanExpectations file since this triggers a change in the order in which scrollbars are layed out. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org > BUG=341815 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171119 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -103 lines) Patch
M LayoutTests/OilpanExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSFontFace.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 5 chunks +3 lines, -8 lines 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 4 chunks +4 lines, -7 lines 0 comments Download
M Source/core/css/FontFaceCache.h View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/css/FontFaceCache.cpp View 4 chunks +15 lines, -21 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 3 chunks +18 lines, -26 lines 0 comments Download
M Source/platform/fonts/FontCacheClient.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/fonts/FontFallbackList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontFallbackList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
wibling-chromium
6 years, 8 months ago (2014-04-09 07:38:32 UTC) #1 
Created Revert of [Oilpan]: Moving the FontSelector/FontCacheClient,
CSSSegmentedFontFace, and FontFaceCache to the o…

Powered by Google App Engine
This is Rietveld 408576698