Add UMA metric to track usage of sending a mousedown to select elements.

Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698
Committed: https://crrev.com/b677a41a4e30b6bf68bc4cd2a9ec8876d5e2f7ea
Cr-Commit-Position: refs/heads/master@{#416193}

[dtapuska, 2016-09-01 20:31:58]

Description was changed from

==========
Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698
==========

to

==========
Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698
==========

[dtapuska, 2016-09-01 20:31:58]

dtapuska@chromium.org changed reviewers:
+ isherman@chromium.org, rbyers@chromium.org

[Ilya Sherman, 2016-09-01 20:38:26]

histograms.xml lgtm

[Rick Byers, 2016-09-01 21:58:56]

LGTM with nits (sorry for all the nits on such a small patch <grin>).

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventDispatcher.cpp (right):

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventDispatcher.cpp:249: // it to open.
This measures a possible breakage of not allow untrusted
nit: s/allow/allowing/

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventDispatcher.cpp:251: if
(!m_event->isTrusted() && m_event->isMouseEvent() &&
toMouseEvent(*m_event).type() == EventTypeNames::mousedown &&
isHTMLSelectElement(*m_node)) {
nit: the toMouseEvent is unnecessary, elsewhere in this file we simply do
"m_event->type()".

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:1279:
UntrustedMouseDownEventDispatched = 1543,
nit: qualify that this is for select nodes.  Eg.
'UntrustedMouseDownEventDispatchedToSelect'.

[dtapuska, 2016-09-02 02:57:08]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-09-02 02:57:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2303013002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-09-02 02:57:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-09-02 02:57:43]

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventDispatcher.cpp (right):

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventDispatcher.cpp:249: // it to open.
This measures a possible breakage of not allow untrusted
On 2016/09/01 21:58:56, Rick Byers wrote:
> nit: s/allow/allowing/

Done.

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventDispatcher.cpp:251: if
(!m_event->isTrusted() && m_event->isMouseEvent() &&
toMouseEvent(*m_event).type() == EventTypeNames::mousedown &&
isHTMLSelectElement(*m_node)) {
On 2016/09/01 21:58:56, Rick Byers wrote:
> nit: the toMouseEvent is unnecessary, elsewhere in this file we simply do
> "m_event->type()".

Done.

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2303013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:1279:
UntrustedMouseDownEventDispatched = 1543,
On 2016/09/01 21:58:56, Rick Byers wrote:
> nit: qualify that this is for select nodes.  Eg.
> 'UntrustedMouseDownEventDispatchedToSelect'.

Done.

[commit-bot: I haz the power, 2016-09-02 05:23:33]

Description was changed from

==========
Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698
==========

to

==========
Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698
==========

[commit-bot: I haz the power, 2016-09-02 05:23:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 05:25:21]

Description was changed from

==========
Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698
==========

to

==========
Add UMA metric to track usage of sending a mousedown to select elements.

There is potential around the fast click library trapping touchend events
and generating mousedown events for android chrome.

Track the usage of this behaviour we are seeing.

BUG=642698

Committed: https://crrev.com/b677a41a4e30b6bf68bc4cd2a9ec8876d5e2f7ea
Cr-Commit-Position: refs/heads/master@{#416193}
==========

[commit-bot: I haz the power, 2016-09-02 05:25:22]

Patchset 2 (id:??) landed as
https://crrev.com/b677a41a4e30b6bf68bc4cd2a9ec8876d5e2f7ea
Cr-Commit-Position: refs/heads/master@{#416193}

[dtapuska, 2016-09-08 15:10:53]

W3C auto test import CL.

TBR=qyearsley@chromium.org

[dtapuska, 2016-09-08 15:14:19]

W3C auto test import CL.

TBR=qyearsley@chromium.org