Simplified BuildFastLiteral by eliminating manual allocation folding.

Simplified BuildFastLiteral by eliminating manual allocation folding.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16422

[Michael Starzinger, 2013-08-16 20:18:56]

Nice cleanup, but still unnecessary complex IMHO.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8189
src/hydrogen.cc:8189: Handle<JSObject> original_boilerplate_object,
Why does this function take the deep-copied boilerplate _and_ the original
boilerplate. That makes no sense, can we get rid of that? It should be
sufficient to just take a boilerplate.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8292
src/hydrogen.cc:8292: Handle<JSObject> original_boilerplate_object,
Likewise.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8359
src/hydrogen.cc:8359: Handle<FixedArrayBase> original_elements,
Likewise.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8398
src/hydrogen.cc:8398: Handle<FixedArrayBase> original_elements,
Likewise.

[Hannes Payer (out of office), 2013-08-22 13:27:23]

This cl requires issue 22903027.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8189
src/hydrogen.cc:8189: Handle<JSObject> original_boilerplate_object,
On 2013/08/16 20:18:56, Michael Starzinger wrote:
> Why does this function take the deep-copied boilerplate _and_ the original
> boilerplate. That makes no sense, can we get rid of that? It should be
> sufficient to just take a boilerplate.

Thanks for the comment, removed. Done.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8292
src/hydrogen.cc:8292: Handle<JSObject> original_boilerplate_object,
On 2013/08/16 20:18:56, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8359
src/hydrogen.cc:8359: Handle<FixedArrayBase> original_elements,
On 2013/08/16 20:18:56, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/23030002/diff/14001/src/hydrogen.cc#newcode8398
src/hydrogen.cc:8398: Handle<FixedArrayBase> original_elements,
On 2013/08/16 20:18:56, Michael Starzinger wrote:
> Likewise.

Done.

[Michael Starzinger, 2013-08-28 08:50:59]

LGTM.

https://codereview.chromium.org/23030002/diff/27001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/23030002/diff/27001/src/hydrogen.cc#newcode4322
src/hydrogen.cc:4322: Handle<Map> map = Handle<Map>(boilerplate_object->map(),
nit: Should fit into one line now.

[Hannes Payer (out of office), 2013-08-29 12:06:54]

Committed patchset #11 manually as r16422 (presubmit successful).