Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2302983002:
Add infra/bots/tasks.json (Closed)
DescriptionAdd infra/bots/tasks.json
This is an initial version which adds a trio of buildbot-less bots. I
expect these to be totally broken while I work out the issues.
In the future, we'll have a script to generate tasks.json.
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002
Committed: https://skia.googlesource.com/skia/+/de3184fd846925d716e8dc530316c1b606e52511
Patch Set 1 #
Total comments: 2
Patch Set 2 : GN #Messages
Total messages: 16 (9 generated)
Description was changed from ========== Add infra/bots/tasks.json This is an initial version which adds a trio of buildbot-less bots. I expect these to be totally broken while I work out the issues. BUG=skia:5626 ========== to ========== Add infra/bots/tasks.json This is an initial version which adds a trio of buildbot-less bots. I expect these to be totally broken while I work out the issues. BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002 ==========
Description was changed from ========== Add infra/bots/tasks.json This is an initial version which adds a trio of buildbot-less bots. I expect these to be totally broken while I work out the issues. BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002 ========== to ========== Add infra/bots/tasks.json This is an initial version which adds a trio of buildbot-less bots. I expect these to be totally broken while I work out the issues. In the future, we'll have a script to generate tasks.json. BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002 ==========
borenet@google.com changed reviewers: + benjaminwagner@google.com, borenet@google.com
The CQ bit was checked by borenet@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mtklein@google.com changed reviewers: + mtklein@google.com
GN! GN! GN!
lgtm https://codereview.chromium.org/2302983002/diff/1/infra/bots/tasks.json File infra/bots/tasks.json (right): https://codereview.chromium.org/2302983002/diff/1/infra/bots/tasks.json#newcode3 infra/bots/tasks.json:3: "Build-Ubuntu-GCC-x86_64-Release-NoBuildbot": { Will recipes just ignore -NoBuildbot? (If not, I think it's fine to use the same name as the Buildbot builder.)
Okay, okay. https://codereview.chromium.org/2302983002/diff/1/infra/bots/tasks.json File infra/bots/tasks.json (right): https://codereview.chromium.org/2302983002/diff/1/infra/bots/tasks.json#newcode3 infra/bots/tasks.json:3: "Build-Ubuntu-GCC-x86_64-Release-NoBuildbot": { On 2016/09/01 19:00:05, Ben Wagner wrote: > Will recipes just ignore -NoBuildbot? (If not, I think it's fine to use the same > name as the Buildbot builder.) Yeah, if the extra_config isn't relevant anywhere, it just gets ignored. At mtklein's request, changed to GN.
The CQ bit was checked by borenet@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from benjaminwagner@google.com Link to the patchset: https://codereview.chromium.org/2302983002/#ps20001 (title: "GN")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/01 19:01:57, borenet wrote: > Okay, okay. > > https://codereview.chromium.org/2302983002/diff/1/infra/bots/tasks.json > File infra/bots/tasks.json (right): > > https://codereview.chromium.org/2302983002/diff/1/infra/bots/tasks.json#newcode3 > infra/bots/tasks.json:3: "Build-Ubuntu-GCC-x86_64-Release-NoBuildbot": { > On 2016/09/01 19:00:05, Ben Wagner wrote: > > Will recipes just ignore -NoBuildbot? (If not, I think it's fine to use the > same > > name as the Buildbot builder.) > > Yeah, if the extra_config isn't relevant anywhere, it just gets ignored. At > mtklein's request, changed to GN. :)
Message was sent while issue was closed.
Description was changed from ========== Add infra/bots/tasks.json This is an initial version which adds a trio of buildbot-less bots. I expect these to be totally broken while I work out the issues. In the future, we'll have a script to generate tasks.json. BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002 ========== to ========== Add infra/bots/tasks.json This is an initial version which adds a trio of buildbot-less bots. I expect these to be totally broken while I work out the issues. In the future, we'll have a script to generate tasks.json. BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002 Committed: https://skia.googlesource.com/skia/+/de3184fd846925d716e8dc530316c1b606e52511 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/de3184fd846925d716e8dc530316c1b606e52511 |
