Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2302963002: device/bluetooth: Add a helper function to BluetoothServiceRecordBlueZ (Closed)

Created:
4 years, 3 months ago by Miao
Modified:
4 years, 3 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Add a helper function to BluetoothServiceRecordBlueZ This adds IsAttributePresented which checks the present of an attribute by the given attribute ID. BUG=b:29314637 TEST=call IsAttributePresented on a predefined service record Committed: https://crrev.com/f4615ab69f8075621a141f464e90f590134cb569 Cr-Commit-Position: refs/heads/master@{#416413}

Patch Set 1 #

Patch Set 2 : Rebase on ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M device/bluetooth/bluez/bluetooth_service_record_bluez.h View 1 chunk +6 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_service_record_bluez.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Miao
4 years, 3 months ago (2016-09-01 18:23:45 UTC) #2
puthik_chromium
lgtm
4 years, 3 months ago (2016-09-02 20:55:23 UTC) #7
Rahul Chaturvedi
lgtm
4 years, 3 months ago (2016-09-02 21:00:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302963002/20001
4 years, 3 months ago (2016-09-02 21:28:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-03 00:40:27 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:41:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4615ab69f8075621a141f464e90f590134cb569
Cr-Commit-Position: refs/heads/master@{#416413}

Powered by Google App Engine
This is Rietveld 408576698