 Chromium Code Reviews
 Chromium Code Reviews Issue 2302913003:
  Add SafeBrowsingNavigationObserver to listen to navigation events  (Closed)
    
  
    Issue 2302913003:
  Add SafeBrowsingNavigationObserver to listen to navigation events  (Closed) 
  | Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc | 
| diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc b/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc | 
| new file mode 100644 | 
| index 0000000000000000000000000000000000000000..45e20d648d39bb3fc96f38dfe76846910dc4ff59 | 
| --- /dev/null | 
| +++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc | 
| @@ -0,0 +1,230 @@ | 
| +// Copyright 2016 The Chromium Authors. All rights reserved. | 
| +// Use of this source code is governed by a BSD-style license that can be | 
| +// found in the LICENSE file. | 
| + | 
| +#include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h" | 
| + | 
| +#include "base/memory/ptr_util.h" | 
| +#include "base/time/time.h" | 
| +#include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h" | 
| +#include "chrome/browser/sessions/session_tab_helper.h" | 
| +#include "content/public/browser/navigation_handle.h" | 
| +#include "content/public/browser/render_frame_host.h" | 
| +#include "content/public/browser/resource_request_details.h" | 
| +#include "content/public/browser/web_contents.h" | 
| +#include "content/public/common/resource_type.h" | 
| + | 
| +using content::WebContents; | 
| + | 
| +namespace { | 
| +const char kWebContentsUserDataKey[] = | 
| + "web_contents_safe_browsing_navigation_observer"; | 
| +} // namespace | 
| + | 
| +namespace safe_browsing { | 
| + | 
| +// SafeBrowsingNavigationObserver::NavigationEvent----------------------------- | 
| +NavigationEvent::NavigationEvent() | 
| + : source_url(), | 
| + source_tab_id(-1), | 
| + source_main_frame_url(), | 
| + original_request_url(), | 
| + target_tab_id(-1), | 
| + frame_id(-1), | 
| + timestamp(base::Time::Now()), | 
| + is_user_initiated(false), | 
| + has_committed(false), | 
| + has_server_redirect(false), | 
| + actual_target_url() {} | 
| + | 
| +NavigationEvent::NavigationEvent(NavigationEvent&& nav_event) | 
| + : source_url(std::move(nav_event.source_url)), | 
| + source_tab_id(std::move(nav_event.source_tab_id)), | 
| + source_main_frame_url(std::move(nav_event.source_main_frame_url)), | 
| + original_request_url(std::move(nav_event.original_request_url)), | 
| + target_tab_id(std::move(nav_event.target_tab_id)), | 
| + frame_id(nav_event.frame_id), | 
| + timestamp(nav_event.timestamp), | 
| + is_user_initiated(nav_event.is_user_initiated), | 
| + has_committed(nav_event.has_committed), | 
| + has_server_redirect(nav_event.has_server_redirect), | 
| + actual_target_url(std::move(nav_event.actual_target_url)) {} | 
| + | 
| +NavigationEvent& NavigationEvent::operator=(NavigationEvent&& nav_event) { | 
| + source_url = std::move(nav_event.source_url); | 
| + source_tab_id = std::move(nav_event.source_tab_id); | 
| + source_main_frame_url = std::move(nav_event.source_main_frame_url); | 
| + original_request_url = std::move(nav_event.original_request_url); | 
| + target_tab_id = std::move(nav_event.target_tab_id); | 
| + frame_id = nav_event.frame_id; | 
| + timestamp = nav_event.timestamp; | 
| + is_user_initiated = nav_event.is_user_initiated; | 
| + has_committed = nav_event.has_committed; | 
| + has_server_redirect = nav_event.has_server_redirect; | 
| + actual_target_url = std::move(nav_event.actual_target_url); | 
| + return *this; | 
| +} | 
| + | 
| +NavigationEvent::~NavigationEvent() {} | 
| + | 
| +// SafeBrowsingNavigationObserver -------------------------------------------- | 
| + | 
| +// static | 
| +void SafeBrowsingNavigationObserver::MaybeCreateForWebContents( | 
| + content::WebContents* web_contents) { | 
| + if (FromWebContents(web_contents)) | 
| + return; | 
| + NOTIMPLEMENTED(); | 
| + // TODO(jialiul): This method will be called by TabHelpers::AttachTabHelpers. | 
| + // Complete this method when the entire class is ready. | 
| +} | 
| + | 
| +// static | 
| +SafeBrowsingNavigationObserver* SafeBrowsingNavigationObserver::FromWebContents( | 
| + content::WebContents* web_contents) { | 
| + return static_cast<SafeBrowsingNavigationObserver*>( | 
| + web_contents->GetUserData(kWebContentsUserDataKey)); | 
| +} | 
| + | 
| +SafeBrowsingNavigationObserver::SafeBrowsingNavigationObserver( | 
| + content::WebContents* contents, | 
| + const scoped_refptr<SafeBrowsingNavigationObserverManager>& manager) | 
| + : content::WebContentsObserver(contents), | 
| + manager_(manager), | 
| + has_user_gesture_(false), | 
| + last_user_gesture_timestamp_(base::Time()) {} | 
| + | 
| +SafeBrowsingNavigationObserver::~SafeBrowsingNavigationObserver() {} | 
| + | 
| +// Called when a navigation started in the WebContents. |navigation_handle| in | 
| +// parameter is unique to this navigation, which will appear in the following | 
| +// DidRedirectNavigation, and DidFinishNavigation too. | 
| +void SafeBrowsingNavigationObserver::DidStartNavigation( | 
| + content::NavigationHandle* navigation_handle) { | 
| + // If we already seen this navigation_handle before, no need to do anything. | 
| + // TODO(jialiul): Need to handle cases where two DidStartNavigation() called | 
| + // by the same navigation. | 
| + if (navigation_handle_map_.find(navigation_handle) != | 
| + navigation_handle_map_.end()) | 
| + return; | 
| + | 
| + // Construct a NavigationEvent based on available information in | 
| + // navigation_handle. | 
| + NavigationEvent nav_event; | 
| + content::RenderFrameHost* host = | 
| + navigation_handle->GetWebContents()->FindFrameByFrameTreeNodeId( | 
| + navigation_handle->GetFrameTreeNodeId()); | 
| + | 
| + // If there was URL previously committed in this render frame host, | 
| 
Charlie Reis
2016/10/19 17:10:46
nit: in the current RenderFrameHost
 
Jialiu Lin
2016/10/21 02:38:38
Done.
 | 
| + // set it as the source url of this navigation. Otherwise, this is the | 
| + // first url going to commit in this frame. We set navigation_handle's URL as | 
| + // the source url. | 
| + // TODO(jialiul): source_url will be inccorect when another frame is targeting | 
| + // this frame. Need to refine this logic after the true initiator details are | 
| + // added to NavigationHandle. | 
| 
Charlie Reis
2016/10/19 17:10:45
Thanks.  Can you add a reference to https://crbug.
 
Jialiu Lin
2016/10/21 02:38:38
Sure. Done.
 | 
| + if (host && host->GetLastCommittedURL().is_valid()) { | 
| + nav_event.source_url = SafeBrowsingNavigationObserverManager::ClearEmptyRef( | 
| + host->GetLastCommittedURL()); | 
| + } else { | 
| + nav_event.source_url = SafeBrowsingNavigationObserverManager::ClearEmptyRef( | 
| + navigation_handle->GetURL()); | 
| + } | 
| + nav_event.original_request_url = | 
| + SafeBrowsingNavigationObserverManager::ClearEmptyRef( | 
| + navigation_handle->GetURL()); | 
| + nav_event.actual_target_url = nav_event.original_request_url; | 
| + | 
| + nav_event.source_tab_id = | 
| + SessionTabHelper::IdForTab(navigation_handle->GetWebContents()); | 
| + nav_event.timestamp = base::Time::Now(); | 
| + nav_event.frame_id = navigation_handle->GetFrameTreeNodeId(); | 
| + | 
| + if (navigation_handle->IsInMainFrame()) { | 
| + nav_event.source_main_frame_url = nav_event.source_url; | 
| + } else { | 
| + nav_event.source_main_frame_url = | 
| + SafeBrowsingNavigationObserverManager::ClearEmptyRef( | 
| + navigation_handle->GetWebContents()->GetLastCommittedURL()); | 
| + } | 
| + if ((has_user_gesture_ && | 
| + !SafeBrowsingNavigationObserverManager::IsUserGestureExpired( | 
| + last_user_gesture_timestamp_)) || | 
| + !navigation_handle->IsRendererInitiated()) { | 
| + nav_event.is_user_initiated = has_user_gesture_; | 
| + manager_->OnUserGestureConsumed(web_contents(), | 
| + last_user_gesture_timestamp_); | 
| + } | 
| + has_user_gesture_ = false; | 
| + navigation_handle_map_.insert( | 
| + std::make_pair(navigation_handle, std::move(nav_event))); | 
| +} | 
| + | 
| +void SafeBrowsingNavigationObserver::DidRedirectNavigation( | 
| + content::NavigationHandle* navigation_handle) { | 
| + // We should have already seen this navigation_handle in DidStartNavigation. | 
| + if (navigation_handle_map_.find(navigation_handle) == | 
| 
Nathan Parker
2016/10/19 22:56:14
I'm not sure if this gets compiled out on release
 
Jialiu Lin
2016/10/21 02:38:38
Done.
 | 
| + navigation_handle_map_.end()) | 
| + NOTREACHED(); | 
| + | 
| + NavigationEvent* nav_event = &navigation_handle_map_[navigation_handle]; | 
| + nav_event->has_server_redirect = true; | 
| + nav_event->actual_target_url = | 
| + SafeBrowsingNavigationObserverManager::ClearEmptyRef( | 
| + navigation_handle->GetURL()); | 
| + nav_event->timestamp = base::Time::Now(); | 
| +} | 
| + | 
| +void SafeBrowsingNavigationObserver::DidFinishNavigation( | 
| + content::NavigationHandle* navigation_handle) { | 
| + if (navigation_handle_map_.find(navigation_handle) == | 
| + navigation_handle_map_.end()) | 
| + NOTREACHED(); | 
| + | 
| + // If it is an error page, we ignore this navigation. | 
| + if (navigation_handle->IsErrorPage()) { | 
| + navigation_handle_map_.erase(navigation_handle); | 
| + return; | 
| + } | 
| + NavigationEvent* nav_event = &navigation_handle_map_[navigation_handle]; | 
| + | 
| + nav_event->has_committed = navigation_handle->HasCommitted(); | 
| + nav_event->target_tab_id = | 
| + SessionTabHelper::IdForTab(navigation_handle->GetWebContents()); | 
| + nav_event->timestamp = base::Time::Now(); | 
| + | 
| + GURL nav_event_key = nav_event->actual_target_url; | 
| + manager_->RecordNavigationEvent(nav_event_key, nav_event); | 
| + navigation_handle_map_.erase(navigation_handle); | 
| +} | 
| + | 
| +void SafeBrowsingNavigationObserver::DidGetResourceResponseStart( | 
| + const content::ResourceRequestDetails& details) { | 
| + // We only care about main frame and sub frame. | 
| + if (details.resource_type != content::RESOURCE_TYPE_MAIN_FRAME && | 
| + details.resource_type != content::RESOURCE_TYPE_SUB_FRAME) { | 
| + return; | 
| + } | 
| + if (!details.url.is_valid() || details.socket_address.IsEmpty()) | 
| + return; | 
| + | 
| + manager_->RecordHostToIpMapping(details.url.host(), | 
| + details.socket_address.host()); | 
| +} | 
| + | 
| +void SafeBrowsingNavigationObserver::DidGetUserInteraction( | 
| + const blink::WebInputEvent::Type type) { | 
| + last_user_gesture_timestamp_ = base::Time::Now(); | 
| + has_user_gesture_ = true; | 
| + // TODO (jialiul): Refine user gesture logic when DidOpenRequestedURL | 
| + // covers all retargetting cases. | 
| + manager_->RecordUserGestureForWebContents(web_contents(), | 
| + last_user_gesture_timestamp_); | 
| +} | 
| + | 
| +void SafeBrowsingNavigationObserver::WebContentsDestroyed() { | 
| + manager_->OnWebContentDestroyed(web_contents()); | 
| + web_contents()->RemoveUserData(kWebContentsUserDataKey); | 
| + // web_contents is null after this function. | 
| +} | 
| + | 
| +} // namespace safe_browsing |