Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc

Issue 2302913003: Add SafeBrowsingNavigationObserver to listen to navigation events (Closed)
Patch Set: nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
6 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager .h"
7 #include "chrome/browser/sessions/session_tab_helper.h"
8 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/test/base/browser_with_test_window_test.h"
10 #include "content/public/test/test_renderer_host.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "ui/base/window_open_disposition.h"
13
14 namespace safe_browsing {
15
16 class SBNavigationObserverTest : public BrowserWithTestWindowTest {
17 public:
18 SBNavigationObserverTest() {}
19 void SetUp() override {
20 BrowserWithTestWindowTest::SetUp();
21 AddTab(browser(), GURL("http://foo/0"));
22 navigation_observer_manager_ = new SafeBrowsingNavigationObserverManager();
23 navigation_observer_ = new SafeBrowsingNavigationObserver(
24 browser()->tab_strip_model()->GetWebContentsAt(0),
25 navigation_observer_manager_);
26 }
27 void TearDown() override {
28 delete navigation_observer_;
29 BrowserWithTestWindowTest::TearDown();
30 }
31 void VerifyNavigationEvent(const GURL& expected_source_url,
32 int expected_source_tab,
33 const GURL& expected_target_url,
34 int expected_target_tab,
35 const GURL& expected_main_frame_url,
36 bool expected_is_user_initiated,
37 bool expected_has_committed,
38 bool expected_has_server_redirect,
39 const GURL& expected_redirect_url,
40 const NavigationEvent& actual_nav_event) {
41 EXPECT_EQ(expected_source_url, actual_nav_event.source_url);
42 EXPECT_EQ(expected_source_tab, actual_nav_event.source_tab_id);
43 EXPECT_EQ(expected_target_url, actual_nav_event.target_url);
44 EXPECT_EQ(expected_target_tab, actual_nav_event.target_tab_id);
45 EXPECT_EQ(expected_main_frame_url, actual_nav_event.main_frame_url);
46 EXPECT_EQ(expected_is_user_initiated, actual_nav_event.is_user_initiated);
47 EXPECT_EQ(expected_has_committed, actual_nav_event.has_committed);
48 EXPECT_EQ(expected_has_server_redirect,
49 actual_nav_event.has_server_redirect);
50 EXPECT_EQ(expected_redirect_url, actual_nav_event.server_redirect_url);
51 }
52
53 SafeBrowsingNavigationObserverManager::NavigationMap* navigation_map() {
54 return navigation_observer_manager_->navigation_map();
55 }
56
57 protected:
58 SafeBrowsingNavigationObserverManager* navigation_observer_manager_;
59 SafeBrowsingNavigationObserver* navigation_observer_;
60
61 private:
62 DISALLOW_COPY_AND_ASSIGN(SBNavigationObserverTest);
63 };
64
65 TEST_F(SBNavigationObserverTest, BasicNavigationAndCommit) {
66 // Navigation in current tab
67 content::NavigationController* controller =
68 &browser()->tab_strip_model()->GetWebContentsAt(0)->GetController();
69 browser()->OpenURL(
70 content::OpenURLParams(GURL("http://foo/1"), content::Referrer(),
71 WindowOpenDisposition::CURRENT_TAB,
72 ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
73 CommitPendingLoad(controller);
74 int tab_id = SessionTabHelper::IdForTab(controller->GetWebContents());
75 auto nav_map = navigation_map();
76 ASSERT_EQ(std::size_t(1), nav_map->size());
77 ASSERT_EQ(std::size_t(1), nav_map->at(GURL("http://foo/1")).size());
78 VerifyNavigationEvent(GURL("http://foo/0"), tab_id, GURL("http://foo/1"),
79 tab_id, GURL("http://foo/0"), true, true, false, GURL(),
80 nav_map->at(GURL("http://foo/1")).at(0));
81 }
82
83 TEST_F(SBNavigationObserverTest, ServerRedirect) {
84 content::RenderFrameHostTester* rfh_tester =
85 content::RenderFrameHostTester::For(
86 browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame());
87 rfh_tester->SimulateNavigationStart(GURL("http://foo/3"));
88 GURL redirect("http://redirect/1");
89 rfh_tester->SimulateRedirect(redirect);
90 rfh_tester->SimulateNavigationCommit(redirect);
91 int tab_id = SessionTabHelper::IdForTab(
92 browser()->tab_strip_model()->GetWebContentsAt(0));
93 auto nav_map = navigation_map();
94 ASSERT_EQ(std::size_t(1), nav_map->size());
95 ASSERT_EQ(std::size_t(1), nav_map->at(redirect).size());
96 VerifyNavigationEvent(GURL("http://foo/0"), tab_id, GURL("http://foo/3"),
97 tab_id, GURL("http://foo/0"), false, true, true,
98 GURL("http://redirect/1"),
99 nav_map->at(GURL("http://redirect/1")).at(0));
100 }
101
102 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698