Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc

Issue 2302913003: Add SafeBrowsingNavigationObserver to listen to navigation events (Closed)
Patch Set: nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
5 #include "chrome/browser/sessions/session_tab_helper.h"
6 #include "chrome/browser/ui/tabs/tab_strip_model.h"
7 #include "chrome/test/base/browser_with_test_window_test.h"
8 #include "content/public/test/test_renderer_host.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/base/window_open_disposition.h"
11
12 namespace safe_browsing {
13
14 class SBNavigationObserverTest : public BrowserWithTestWindowTest {
15 public:
16 SBNavigationObserverTest() {}
17 void SetUp() override {
18 BrowserWithTestWindowTest::SetUp();
19 AddTab(browser(), GURL("chrome://blank"));
20 navigation_observer_manager_ = new SBNavigationObserverManager();
21 navigation_observer_ = new SafeBrowsingNavigationObserver(
22 browser()->tab_strip_model()->GetWebContentsAt(0),
23 navigation_observer_manager_);
24 }
25 void TearDown() override {
26 delete navigation_observer_;
27 BrowserWithTestWindowTest::TearDown();
28 }
29 void VerifyNavigationEvent(const GURL& expected_source_url,
30 int expected_source_tab,
31 const GURL& expected_target_url,
32 int expected_target_tab,
33 const GURL& expected_main_frame_url,
34 bool expected_is_user_initiated,
35 bool expected_has_committed,
36 bool expected_is_server_redirect,
37 const GURL& expected_redirect_url,
38 const NavigationEvent& actual_nav_event) {
39 EXPECT_EQ(expected_source_url, actual_nav_event.source_url);
40 EXPECT_EQ(expected_source_tab, actual_nav_event.source_tab_id);
41 EXPECT_EQ(expected_target_url, actual_nav_event.target_url);
42 EXPECT_EQ(expected_target_tab, actual_nav_event.target_tab_id);
43 EXPECT_EQ(expected_main_frame_url, actual_nav_event.main_frame_url);
44 EXPECT_EQ(expected_is_user_initiated, actual_nav_event.is_user_initiated);
45 EXPECT_EQ(expected_has_committed, actual_nav_event.has_committed);
46 EXPECT_EQ(expected_is_server_redirect, actual_nav_event.is_server_redirect);
47 EXPECT_EQ(expected_redirect_url, actual_nav_event.server_redirect_url);
48 }
49
50 SBNavigationObserverManager::NavigationMap* navigation_map() {
51 return navigation_observer_manager_->navigation_map();
52 }
53
54 protected:
55 SBNavigationObserverManager* navigation_observer_manager_;
56 SafeBrowsingNavigationObserver* navigation_observer_;
57
58 private:
59 DISALLOW_COPY_AND_ASSIGN(SBNavigationObserverTest);
60 };
61
62 TEST_F(SBNavigationObserverTest, BasicNavigationAndCommit) {
63 // Navigation in current tab
64 content::NavigationController* controller =
65 &browser()->tab_strip_model()->GetWebContentsAt(0)->GetController();
66 browser()->OpenURL(
67 content::OpenURLParams(GURL("http://foo/1"), content::Referrer(),
68 WindowOpenDisposition::CURRENT_TAB,
69 ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
70 CommitPendingLoad(controller);
71 int tab_id = SessionTabHelper::IdForTab(controller->GetWebContents());
72 auto nav_map = navigation_map();
73 ASSERT_EQ(std::size_t(1), nav_map->size());
74 ASSERT_EQ(std::size_t(1), nav_map->at(GURL("http://foo/1")).size());
75 VerifyNavigationEvent(GURL("chrome://blank/"), tab_id, GURL("http://foo/1"),
76 tab_id, GURL("chrome://blank/"), true, true, false,
77 GURL(), nav_map->at(GURL("http://foo/1")).at(0));
78 }
79
80 TEST_F(SBNavigationObserverTest, ServerRedirect) {
81 content::RenderFrameHostTester* rfh_tester =
82 content::RenderFrameHostTester::For(
83 browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame());
84 rfh_tester->SimulateNavigationStart(GURL("http://foo/3"));
85 GURL redirect("http://redirect/1");
86 rfh_tester->SimulateRedirect(redirect);
87 rfh_tester->SimulateNavigationCommit(redirect);
88 int tab_id = SessionTabHelper::IdForTab(
89 browser()->tab_strip_model()->GetWebContentsAt(0));
90 auto nav_map = navigation_map();
91 ASSERT_EQ(std::size_t(1), nav_map->size());
92 ASSERT_EQ(std::size_t(1), nav_map->at(redirect).size());
93 VerifyNavigationEvent(GURL("chrome://blank/"), tab_id, GURL("http://foo/3"),
94 tab_id, GURL("chrome://blank/"), false, true, true,
95 GURL("http://redirect/1"),
96 nav_map->at(GURL("http://redirect/1")).at(0));
97 }
98
99 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698