|
|
Created:
4 years, 3 months ago by seantopping Modified:
4 years, 3 months ago Reviewers:
slan CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionProtect webrtc-dependent tests with enable_webrtc=true
Moving unittests which depend on files moved under enable_webtrc by
http://crrev.com/2287263003
BUG=none
TEST=content_unittests with enable_webtrc=true
Committed: https://crrev.com/bec2fb8ec8b8d42e2280511d2da1f99b418d4020
Cr-Commit-Position: refs/heads/master@{#416272}
Patch Set 1 #Patch Set 2 : Point to the right target this time #
Messages
Total messages: 15 (9 generated)
Message was sent while issue was closed.
Description was changed from ========== Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true ========== to ========== Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true ==========
seantopping@chromium.org changed reviewers: + slan@chromium.org
Lgtm On Thu, Sep 1, 2016, 7:50 PM <seantopping@chromium.org> wrote: > Reviewers: slan > CL: https://codereview.chromium.org/2302903004/ > > Description: > Protect webrtc-dependent tests with enable_webrtc=true > > Moving unittests which depend on files moved under enable_webtrc by > http://crrev.com/2287263003 > > BUG=none > TEST=content_unittests with enable_webtrc=true > > Affected files (+2, -2 lines): > M content/content_tests.gypi > > > Index: content/content_tests.gypi > diff --git a/content/content_tests.gypi b/content/content_tests.gypi > index > 0a47676dccd8a56c5c05e04129681cd22b579e5b..07f2e993016ba0fd66b6250e4b42f9b348d87402 > 100644 > --- a/content/content_tests.gypi > +++ b/content/content_tests.gypi > @@ -732,8 +732,6 @@ > 'renderer/media/audio_message_filter_unittest.cc', > 'renderer/media/audio_renderer_mixer_manager_unittest.cc', > 'renderer/media/audio_renderer_sink_cache_unittest.cc', > - 'renderer/media/html_audio_element_capturer_source_unittest.cc', > - 'renderer/media/media_stream_audio_unittest.cc', > 'renderer/media/midi_message_filter_unittest.cc', > 'renderer/media/mock_audio_device_factory.cc', > 'renderer/media/mock_audio_device_factory.h', > @@ -792,9 +790,11 @@ > 'renderer/media/canvas_capture_handler_unittest.cc', > 'renderer/media/gpu/rtc_video_decoder_unittest.cc', > 'renderer/media/gpu/rtc_video_encoder_unittest.cc', > + 'renderer/media/html_audio_element_capturer_source_unittest.cc', > 'renderer/media/html_video_element_capturer_source_unittest.cc', > 'renderer/media/media_recorder_handler_unittest.cc', > 'renderer/media/media_stream_audio_processor_unittest.cc', > + 'renderer/media/media_stream_audio_unittest.cc', > 'renderer/media/media_stream_constraints_util_unittest.cc', > 'renderer/media/media_stream_dispatcher_unittest.cc', > 'renderer/media/media_stream_video_capturer_source_unittest.cc', > > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by seantopping@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by slan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true ========== to ========== Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true ========== to ========== Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true Committed: https://crrev.com/bec2fb8ec8b8d42e2280511d2da1f99b418d4020 Cr-Commit-Position: refs/heads/master@{#416272} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bec2fb8ec8b8d42e2280511d2da1f99b418d4020 Cr-Commit-Position: refs/heads/master@{#416272} |