Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2302903004: Protect webrtc-dependent tests with enable_webrtc=true (Closed)

Created:
4 years, 3 months ago by seantopping
Modified:
4 years, 3 months ago
Reviewers:
slan
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Protect webrtc-dependent tests with enable_webrtc=true Moving unittests which depend on files moved under enable_webtrc by http://crrev.com/2287263003 BUG=none TEST=content_unittests with enable_webtrc=true Committed: https://crrev.com/bec2fb8ec8b8d42e2280511d2da1f99b418d4020 Cr-Commit-Position: refs/heads/master@{#416272}

Patch Set 1 #

Patch Set 2 : Point to the right target this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
seantopping
4 years, 3 months ago (2016-09-02 02:50:52 UTC) #3
slan
Lgtm On Thu, Sep 1, 2016, 7:50 PM <seantopping@chromium.org> wrote: > Reviewers: slan > CL: ...
4 years, 3 months ago (2016-09-02 03:00:32 UTC) #4
slan
lgtm
4 years, 3 months ago (2016-09-02 14:45:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302903004/20001
4 years, 3 months ago (2016-09-02 14:45:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 15:42:58 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 15:45:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bec2fb8ec8b8d42e2280511d2da1f99b418d4020
Cr-Commit-Position: refs/heads/master@{#416272}

Powered by Google App Engine
This is Rietveld 408576698