Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2302903002: Revert of 🚀 Add dex info and static initializers to resource_sizes.py (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add dex info and static initializers to resource_sizes.py (patchset #2 id:70001 of https://codereview.chromium.org/2294093006/ ) Reason for revert: Broke it again due to crazy.libchrome.so Original issue's description: > Reland of Add dex info and static initializers to resource_sizes.py > > First attempt: > https://codereview.chromium.org/2243343004/ > > Reason for reland: > Now ignores placeholder .so files > > The goal is to have a single script that reports all .apk > size related metrics. > > * Uses method_count.py to get dex info. > * Already had static initializer logic, but now shows it even without > --so_with_symbols_path. > * Tweaks the static initializer count logic to sum up rather for all > .so files rather than report the same metric repeatedly. > > TBR=rnephew@chromium.org,amineer@chromium.org > BUG=609365 > > Committed: https://crrev.com/fe79dde87a12036cc563383e38508b8aad298fd6 > Cr-Commit-Position: refs/heads/master@{#415725} TBR=rnephew@chromium.org,amineer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609365 Committed: https://crrev.com/cdfa05e00a3bd1aaae4a5fd3b2ed56559a6b9e4e Cr-Commit-Position: refs/heads/master@{#415945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -66 lines) Patch
M build/android/method_count.py View 5 chunks +8 lines, -8 lines 0 comments Download
M build/android/resource_sizes.py View 6 chunks +14 lines, -58 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
agrieve
Created Revert of 🚀 Add dex info and static initializers to resource_sizes.py
4 years, 3 months ago (2016-09-01 14:13:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302903002/1
4 years, 3 months ago (2016-09-01 14:13:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 14:14:21 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdfa05e00a3bd1aaae4a5fd3b2ed56559a6b9e4e Cr-Commit-Position: refs/heads/master@{#415945}
4 years, 3 months ago (2016-09-01 14:15:46 UTC) #10
agrieve
4 years, 3 months ago (2016-09-01 15:34:48 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2299193002/ by agrieve@chromium.org.

The reason for reverting is: will update when fixed..

Powered by Google App Engine
This is Rietveld 408576698