Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2302873004: Renamed WebRTCStats.h to WebRTCLegacyStats.h and cleaned it up (Closed)

Created:
4 years, 3 months ago by hbos_chromium
Modified:
4 years, 3 months ago
Reviewers:
perkj_chrome, Mike West
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed WebRTCStats.h to WebRTCLegacyStats.h and cleaned it up. Changes: - WebRTCStats.h renamed to WebRTCLegacyStats.h - Removed WebRTCStatsType and WebRTCStatsMemberName - not used - Renamed WebRTCStats and WebRTCStatsMemberIterator to WebRTCLegacyStats and WebRTCLegacyStatsMemberIterator - Updated affected code These classes/enums are used to surface stats from the WebRTC repo to Blink. They were originally added to support both the old stats and the new stats which are currently being added to the WebRTC repo. Because we decided to add the new stats using a new stats collection API, we'll want to surface the new stats into Blink differently. We rename these classes/enums as to not confuse the classes relating to the new stats ("RTCStats") with the classes relating to the old stats ("RTCLegacyStatsReport"). More classes should be renamed in separate CLs. BUG=chromium:627816 Committed: https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772 Cr-Commit-Position: refs/heads/master@{#416532}

Patch Set 1 : Renamed WebRTCStats.h -> WebRTCLegacyStats.h #

Patch Set 2 : Renamed and removed stuff in WebRTCLegacyStats.h, updated code using it #

Patch Set 3 : Fixed compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -143 lines) Patch
M components/test_runner/mock_webrtc_peer_connection_handler.cc View 1 3 chunks +13 lines, -19 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 5 chunks +21 lines, -38 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/public/platform/WebRTCLegacyStats.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
D third_party/WebKit/public/platform/WebRTCStats.h View 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCStatsResponse.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
hbos_chromium
Please take a look, mkwst and perkj
4 years, 3 months ago (2016-09-05 10:03:17 UTC) #13
Mike West
LGTM. Will you be removing the legacy files at some point in the future?
4 years, 3 months ago (2016-09-05 10:05:44 UTC) #14
hbos_chromium
PTAL perkj. On 2016/09/05 10:05:44, Mike West (OOO until 29th) wrote: > LGTM. Will you ...
4 years, 3 months ago (2016-09-05 10:12:15 UTC) #15
perkj_chrome
On 2016/09/05 10:12:15, hbos_chromium wrote: > PTAL perkj. > > On 2016/09/05 10:05:44, Mike West ...
4 years, 3 months ago (2016-09-05 10:15:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302873004/40001
4 years, 3 months ago (2016-09-05 10:22:01 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-05 11:52:47 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 11:54:02 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b89aa18be2df6bde8251331255251b9c18c1d772
Cr-Commit-Position: refs/heads/master@{#416532}

Powered by Google App Engine
This is Rietveld 408576698