Issue 2302873003: Update co19 status for dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2302873003: Update co19 status for dartium (Closed)

Created:
4 years, 3 months ago by Bill Hesse

Modified:
4 years, 3 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update co19 status for dartium BUG= TBR=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/c76badd899cca1a56a100a8a43aa4b0ffddff9bd

Patch Set 1 #

Total comments: 2

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -23 lines)			Patch
	M	tests/co19/co19-dartium.status	View		15 chunks	+41 lines, -23 lines	2 comments	Download
	M	tests/co19/co19-runtime.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

Committed patchset #1 (id:1) manually as c76badd899cca1a56a100a8a43aa4b0ffddff9bd (presubmit successful).

4 years, 3 months ago (2016-09-01 17:01:23 UTC) #3

terry

4 years, 3 months ago (2016-09-01 17:53:56 UTC) #4

Message was sent while issue was closed.

Isolate.spawn doesn't work in dart2js or Dartium also looks like all spawnUri
tests are failing (how are they failing?).

Can all the tests in isolate/Isolate never be run for Dart2Js/Dartium - en mass
for the directory?  So we can eliminate the status file entries?

https://codereview.chromium.org/2302873003/diff/1/tests/co19/co19-dartium.status
File tests/co19/co19-dartium.status (right):

https://codereview.chromium.org/2302873003/diff/1/tests/co19/co19-dartium.sta...
tests/co19/co19-dartium.status:212:
Language/Expressions/Method_Invocation/Ordinary_Invocation/syntax_t05: Pass
Why is this line necessary is it passes?

https://codereview.chromium.org/2302873003/diff/1/tests/co19/co19-dartium.sta...
tests/co19/co19-dartium.status:219:
Language/Functions/Formal_Parameters/syntax_t05: Pass
Why is this line necessary is it passes?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages