Issue 2302873002: Merged: Fix compilation error on gcc 4.8.5 on s390x

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2302873002: Merged: Fix compilation error on gcc 4.8.5 on s390x (Closed)

Created:
4 years, 3 months ago by john.yan

Modified:
4 years, 3 months ago

Reviewers:
Benedikt Meurer, mvstanton

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan

Target Ref:
refs/pending/branch-heads/5.4

Project:
v8

Visibility:
Public.

Merged: Fix compilation error on gcc 4.8.5 on s390x Revision: d8792ab NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org, mvstanton@chromium.org BUG=

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/base/ieee754.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (1 generated)

john.yan

NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...

4 years, 3 months ago (2016-09-01 13:56:03 UTC) #2

john.yan

On 2016/09/01 13:55:57, john.yan wrote: https://bugs.chromium.org/p/v8/issues/detail?id=5340

4 years, 3 months ago (2016-09-01 13:56:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302873002/1

4 years, 3 months ago (2016-09-01 20:36:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1)