Move Skia GN sources to a separate .gni file.

Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.

Marks skia_for_chromium_defines as obsolete and moves the definition into the new .gni file. We can remove the .gypi file when Chrome is updated.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005

Committed: https://skia.googlesource.com/skia/+/b944728b93a1623d73be31413a6798e0b7dddc16

[brettw, 2016-09-01 20:35:06]

Description was changed from

==========
Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.
==========

to

==========
Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005
==========

[brettw, 2016-09-01 20:36:44]

Description was changed from

==========
Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005
==========

to

==========
Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.

Marks skia_for_chromium_defines as obsolete and moves the definition into the
new .gni file. We can remove the .gypi file when Chrome is updated.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005
==========

[brettw, 2016-09-01 20:36:44]

brettw@chromium.org changed reviewers:
+ mtklein@chromium.org

[brettw, 2016-09-01 20:41:42]

Once this rolls in I can land this Chrome change I just added you as a reviewer
for:
https://codereview.chromium.org/2301233002/

Then we can write most changes as one-sided changes to the Skia build layout.

[brettw, 2016-09-01 20:41:46]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 20:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-01 20:54:38]

https://codereview.chromium.org/2302803005/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2302803005/diff/1/BUILD.gn#newcode405
BUILD.gn:405: "//src/gpu/gl/GrGLCreateNativeInterface_none.cpp",
Fuchsia pulls Skia in and uses this BUILD.gn file in their environment where
skia/ is not the root.  This will break that, right?

https://codereview.chromium.org/2302803005/diff/1/gn/shared_sources.gni
File gn/shared_sources.gni (right):

https://codereview.chromium.org/2302803005/diff/1/gn/shared_sources.gni#newco...
gn/shared_sources.gni:95: # become 'permanent', they should be moved into
skia_common.gypi
-> Chrome's skia/BUILD.gn ?

[brettw, 2016-09-01 20:58:13]

fixes

[brettw, 2016-09-01 20:58:14]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 20:58:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-01 20:58:42]

https://codereview.chromium.org/2302803005/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2302803005/diff/1/BUILD.gn#newcode405
BUILD.gn:405: "//src/gpu/gl/GrGLCreateNativeInterface_none.cpp",
On 2016/09/01 20:54:38, mtklein_C wrote:
> Fuchsia pulls Skia in and uses this BUILD.gn file in their environment where
> skia/ is not the root.  This will break that, right?

I didn't know that. I changed this so it will work in all cases.

https://codereview.chromium.org/2302803005/diff/1/gn/shared_sources.gni
File gn/shared_sources.gni (right):

https://codereview.chromium.org/2302803005/diff/1/gn/shared_sources.gni#newco...
gn/shared_sources.gni:95: # become 'permanent', they should be moved into
skia_common.gypi
On 2016/09/01 20:54:38, mtklein_C wrote:
> -> Chrome's skia/BUILD.gn ?

Done.

[mtklein_C, 2016-09-01 21:00:29]

lgtm

[brettw, 2016-09-01 21:03:56]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-09-01 21:04:00]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-01 21:04:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:24:41]

Description was changed from

==========
Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.

Marks skia_for_chromium_defines as obsolete and moves the definition into the
new .gni file. We can remove the .gypi file when Chrome is updated.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005
==========

to

==========
Move Skia GN sources to a separate .gni file.

This file will be imported by Chrome to access the sources lists.

Once Chrome is updated to use this file, changes to the skia .gypi layout can
be done entirely within the skia repository as long as the resulting lists
produced by the new .gni file have the same name.

Marks skia_for_chromium_defines as obsolete and moves the definition into the
new .gni file. We can remove the .gypi file when Chrome is updated.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005

Committed:
https://skia.googlesource.com/skia/+/b944728b93a1623d73be31413a6798e0b7dddc16
==========

[commit-bot: I haz the power, 2016-09-01 21:24:42]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b944728b93a1623d73be31413a6798e0b7dddc16