Issue 2302803004: [chromedriver] Set |key| when calling Input.dispatchKeyEvent.

Issue 2302803004: [chromedriver] Set |key| when calling Input.dispatchKeyEvent. (Closed)

Created:
4 years, 3 months ago by samuong

Modified:
4 years, 3 months ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[chromedriver] Set |key| when calling Input.dispatchKeyEvent. BUG=chromedriver:1484, chromedriver:1411 Committed: https://crrev.com/e4575053ef8633b2ea57ad4936e4e5d3ff42f36d Cr-Commit-Position: refs/heads/master@{#416149}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
M	chrome/test/chromedriver/chrome/web_view_impl.cc	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/client/chromedriver.py	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/test/run_py_tests.py	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	chrome/test/data/chromedriver/two_inputs.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 11 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302803004/40001

4 years, 3 months ago (2016-09-01 22:43:59 UTC) #6

commit-bot: I haz the power

4 years, 3 months ago (2016-09-02 01:01:54 UTC) #11

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/e4575053ef8633b2ea57ad4936e4e5d3ff42f36d
Cr-Commit-Position: refs/heads/master@{#416149}