Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2302803003: Remove empty {lsan,ubsan}.supp files. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove empty {lsan,ubsan}.supp files. We never used ubsan.supp, and LSAN suppressions are now built into the test binaries. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Committed: https://skia.googlesource.com/skia/+/b987afa7cca850c6cac9918fced337ad3bb902cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M infra/bots/infrabots.isolate View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipe_modules/flavor/xsan_flavor.py View 1 chunk +1 line, -5 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 chunk +2 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +2 lines, -3 lines 0 comments Download
D tools/lsan.supp View 1 chunk +0 lines, -1 line 0 comments Download
D tools/ubsan.supp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-01 14:14:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302803003/1
4 years, 3 months ago (2016-09-01 14:14:27 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-01 14:14:29 UTC) #7
borenet
LGTM
4 years, 3 months ago (2016-09-01 14:20:47 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:08:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b987afa7cca850c6cac9918fced337ad3bb902cf

Powered by Google App Engine
This is Rietveld 408576698