Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: src/debug/debug-scopes.cc

Issue 2302783002: [modules] Basic support of exports (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug-scopes.cc
diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc
index 2afa8237130d2d9a0de89f5a42d60d4f0cb266ac..daa39e9e41247722f6464193850e4d1f7d216482 100644
--- a/src/debug/debug-scopes.cc
+++ b/src/debug/debug-scopes.cc
@@ -363,6 +363,7 @@ bool ScopeIterator::SetVariableValue(Handle<String> variable_name,
return SetInnerScopeVariableValue(variable_name, new_value);
case ScopeIterator::ScopeTypeModule:
// TODO(2399): should we implement it?
+ // XXX
break;
}
return false;
@@ -617,6 +618,8 @@ MaybeHandle<JSObject> ScopeIterator::MaterializeModuleScope() {
// Fill all context locals.
CopyContextLocalsToScopeObject(scope_info, context, module_scope);
+ // XXX stack locals. maybe even imports/exports?
+
return module_scope;
}

Powered by Google App Engine
This is Rietveld 408576698