Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2302763003: WebRTCBrowserTests.MAYBE_MANUAL_FirefoxApprtcInteropTest (Closed)

Created:
4 years, 3 months ago by perkj_chrome
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable WebRTCBrowserTests.MANUAL_FirefoxApprtcInteropTest This test pass locally and we want to run it on the webrtc build bots. This reverts commit f472eb573a7e50134d78aac9117f37f26e205dce. BUG=626556 NOTRY=true TBR=phoglund@chromium.org Committed: https://crrev.com/c71d7e55a9a5915f6e3417e6214138e87cd28789 Cr-Commit-Position: refs/heads/master@{#416243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/media/webrtc_apprtc_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
perkj_chrome
please
4 years, 3 months ago (2016-09-02 10:59:59 UTC) #3
kjellander_chromium
lgtm
4 years, 3 months ago (2016-09-02 11:02:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302763003/1
4 years, 3 months ago (2016-09-02 11:22:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/252021)
4 years, 3 months ago (2016-09-02 11:29:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302763003/1
4 years, 3 months ago (2016-09-02 12:03:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 12:07:41 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 12:08:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c71d7e55a9a5915f6e3417e6214138e87cd28789
Cr-Commit-Position: refs/heads/master@{#416243}

Powered by Google App Engine
This is Rietveld 408576698