Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2302743003: Inline extensions .gypi files into GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline extensions .gypi files into GN build. Delete obsolete files. Committed: https://crrev.com/3728a5477b57d5b0e8ad47bea9b5ab50c0a23272 Cr-Commit-Position: refs/heads/master@{#416356}

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Fixes #

Patch Set 4 : ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1332 lines, -2746 lines) Patch
M .gn View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/BUILD.gn View 1 2 chunks +56 lines, -4 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 3 chunks +644 lines, -30 lines 0 comments Download
D extensions/browser/api/api_registration.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
M extensions/common/BUILD.gn View 4 chunks +224 lines, -21 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 2 4 chunks +76 lines, -5 lines 0 comments Download
D extensions/common/api/api.gyp View 1 chunk +0 lines, -61 lines 0 comments Download
D extensions/common/api/schemas.gni View 1 chunk +0 lines, -18 lines 0 comments Download
D extensions/common/api/schemas.gypi View 1 chunk +0 lines, -86 lines 0 comments Download
D extensions/components/extensions_components.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D extensions/extensions.gni View 1 chunk +0 lines, -16 lines 0 comments Download
D extensions/extensions.gyp View 1 chunk +0 lines, -336 lines 0 comments Download
D extensions/extensions.gypi View 1 chunk +0 lines, -1147 lines 0 comments Download
D extensions/extensions_resources.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D extensions/extensions_strings.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
M extensions/renderer/BUILD.gn View 2 chunks +207 lines, -9 lines 0 comments Download
M extensions/shell/BUILD.gn View 5 chunks +116 lines, -36 lines 0 comments Download
D extensions/shell/app_shell.gni View 1 chunk +0 lines, -16 lines 0 comments Download
D extensions/shell/app_shell.gyp View 1 chunk +0 lines, -410 lines 0 comments Download
D extensions/shell/app_shell.gypi View 1 chunk +0 lines, -137 lines 0 comments Download
D extensions/shell/app_shell_resources.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D extensions/shell/browser/api/api_registration.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
M extensions/shell/common/api/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
D extensions/shell/common/api/api.gyp View 1 chunk +0 lines, -100 lines 0 comments Download
D extensions/shell/common/api/schemas.gni View 1 chunk +0 lines, -17 lines 0 comments Download
D extensions/shell/common/api/schemas.gypi View 1 chunk +0 lines, -33 lines 0 comments Download
D extensions/test/test_api.gyp View 1 chunk +0 lines, -87 lines 0 comments Download
M extensions/utility/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
brettw
4 years, 3 months ago (2016-09-01 23:08:31 UTC) #2
brettw
Merge
4 years, 3 months ago (2016-09-01 23:09:36 UTC) #5
brettw
Fixes
4 years, 3 months ago (2016-09-02 16:42:26 UTC) #10
brettw
ChromeOS
4 years, 3 months ago (2016-09-02 16:58:45 UTC) #15
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-09-02 21:28:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302743003/60001
4 years, 3 months ago (2016-09-02 21:51:19 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 21:56:49 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 21:58:41 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3728a5477b57d5b0e8ad47bea9b5ab50c0a23272
Cr-Commit-Position: refs/heads/master@{#416356}

Powered by Google App Engine
This is Rietveld 408576698