Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: filter/count/gi.go

Issue 2302743002: Interface update, per-method Contexts. (Closed)
Patch Set: Lightning talk licenses. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filter/count/count_test.go ('k') | filter/count/mail.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/count/gi.go
diff --git a/filter/count/gi.go b/filter/count/gi.go
index 5888ca940ccebd6b0a7e836cead8c49c4fa9c16f..e5932da6dfa90c9b46bb2040580e5c761f8b2221 100644
--- a/filter/count/gi.go
+++ b/filter/count/gi.go
@@ -53,7 +53,7 @@ func (g *infoCounter) FullyQualifiedAppID() string {
return g.gi.FullyQualifiedAppID()
}
-func (g *infoCounter) GetNamespace() (string, bool) {
+func (g *infoCounter) GetNamespace() string {
_ = g.c.GetNamespace.up()
return g.gi.GetNamespace()
}
@@ -118,9 +118,10 @@ func (g *infoCounter) VersionID() string {
return g.gi.VersionID()
}
-func (g *infoCounter) Namespace(namespace string) (context.Context, error) {
- ret, err := g.gi.Namespace(namespace)
- return ret, g.c.Namespace.up(err)
+func (g *infoCounter) Namespace(namespace string) (c context.Context, err error) {
+ c, err = g.gi.Namespace(namespace)
+ g.c.Namespace.up(err)
+ return
}
func (g *infoCounter) AccessToken(scopes ...string) (string, time.Time, error) {
@@ -138,8 +139,8 @@ func (g *infoCounter) SignBytes(bytes []byte) (string, []byte, error) {
return keyName, signature, g.c.SignBytes.up(err)
}
-func (g *infoCounter) Testable() info.Testable {
- return g.gi.Testable()
+func (g *infoCounter) GetTestable() info.Testable {
+ return g.gi.GetTestable()
}
// FilterGI installs a counter GlobalInfo filter in the context.
« no previous file with comments | « filter/count/count_test.go ('k') | filter/count/mail.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698