Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: filter/txnBuf/ds_txn.go

Issue 2302743002: Interface update, per-method Contexts. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: filter/txnBuf/ds_txn.go
diff --git a/filter/txnBuf/ds_txn.go b/filter/txnBuf/ds_txn.go
index 7b25c607d2d4fc2a003d0a2ab8679d94be086929..35101a5cb967f0a82c4ad503494f04ecf50bebdd 100644
--- a/filter/txnBuf/ds_txn.go
+++ b/filter/txnBuf/ds_txn.go
@@ -116,6 +116,12 @@ func (d *dsTxnBuf) RunInTransaction(cb func(context.Context) error, opts *ds.Tra
return withTxnBuf(d.ic, cb, opts)
}
-func (d *dsTxnBuf) Testable() ds.Testable {
- return d.state.parentDS.Testable()
+func (d *dsTxnBuf) CurrentTransaction() ds.Transaction { return d.state.parentDS.CurrentTransaction() }
dnj 2016/09/01 15:25:39 Perhaps in the future, we can synthesize transacti
iannucci 2016/09/16 01:01:13 hm good point. Yes I think waiting on this is a go
dnj 2016/09/16 05:44:42 Done.
+
+func (d *dsTxnBuf) WithTransaction(t ds.Transaction) context.Context {
+ return d.state.parentDS.WithTransaction(nil)
iannucci 2016/09/16 01:01:13 doesn't this need to remove transaction stuff from
dnj 2016/09/16 05:44:42 Done.
+}
+
+func (d *dsTxnBuf) GetTestable() ds.Testable {
+ return nil
dnj 2016/09/01 15:25:39 oops, I'll make sure this returns parentDS's Testa
dnj 2016/09/16 05:44:42 Done.
}

Powered by Google App Engine
This is Rietveld 408576698