Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2302693002:
bluetooth: web: Update Blacklist with Cypress & FIDO services. (Closed)
|
Created:
4 years, 3 months ago by scheib Modified:
4 years, 3 months ago Reviewers:
Jeffrey Yasskin CC:
chromium-reviews, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionbluetooth: web: Update Blacklist with Cypress & FIDO services.
https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt
has been updated to include 2 additional blacklisted services.
Cypress bootloader service 00060000
https://github.com/WebBluetoothCG/registries/pull/13
FIDO authentication service fffd
https://github.com/WebBluetoothCG/registries/pull/14
Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end.
BUG=570121, 643013
Committed: https://crrev.com/783cbf77c054a6b31529d8031eefcd11b97f65b7
Cr-Commit-Position: refs/heads/master@{#416184}
Patch Set 1 #Patch Set 2 : fix test #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== bluetooth: Update Web Bluetooth Blacklist items. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. https://github.com/WebBluetoothCG/registries/pull/13 https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhastive tests at the end. BUG=570121, 643013 ========== to ========== bluetooth: Update Web Bluetooth Blacklist items. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhastive tests at the end. BUG=570121, 643013 ==========
scheib@chromium.org changed reviewers: + jyasskin@chromium.org
Description was changed from ========== bluetooth: Update Web Bluetooth Blacklist items. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhastive tests at the end. BUG=570121, 643013 ========== to ========== bluetooth: Update Web Bluetooth Blacklist items. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 ==========
Description was changed from ========== bluetooth: Update Web Bluetooth Blacklist items. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 ========== to ========== bluetooth: web: Update Blacklist with Cypress & FIDO services. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM; thanks!
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== bluetooth: web: Update Blacklist with Cypress & FIDO services. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 ========== to ========== bluetooth: web: Update Blacklist with Cypress & FIDO services. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== bluetooth: web: Update Blacklist with Cypress & FIDO services. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 ========== to ========== bluetooth: web: Update Blacklist with Cypress & FIDO services. https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated to include 2 additional blacklisted services. Cypress bootloader service 00060000 https://github.com/WebBluetoothCG/registries/pull/13 FIDO authentication service fffd https://github.com/WebBluetoothCG/registries/pull/14 Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end. BUG=570121, 643013 Committed: https://crrev.com/783cbf77c054a6b31529d8031eefcd11b97f65b7 Cr-Commit-Position: refs/heads/master@{#416184} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/783cbf77c054a6b31529d8031eefcd11b97f65b7 Cr-Commit-Position: refs/heads/master@{#416184} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
