Make StateData private

Make CPDF_GeneralStateData private.

All interaction goes through the CPDF_GeneralState, which
manages the underlying storage transparently to the callers.

Make StateData use a real string and a real matrix rather
than C-style arrays.

Committed: https://pdfium.googlesource.com/pdfium/+/e106b50129d5b8ce50228c67d3b0170bc46c4b2e

[Tom Sepez, 2016-09-01 00:45:22]

Description was changed from

==========
Make StateData private

BUG=
==========

to

==========
Make CPDF_GeneralStateData private.

All interaction goes through the CPDF_GeneralState, which
manages the underlying storage transparently to the callers.
==========

[Tom Sepez, 2016-09-01 00:45:22]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-01 00:45:39]

Dan, how about them apples?

[dsinclair, 2016-09-01 14:17:09]

lgtm w/ nits

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_generalstate.cpp (right):

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:214:
FXSYS_strcpy((FX_CHAR*)m_BlendMode, "Normal");
static_cast

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:224: if (src.m_pTransferFunc &&
src.m_pTransferFunc->m_pPDFDoc) {
invert and early return?

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:235: if (m_pTransferFunc &&
m_pTransferFunc->m_pPDFDoc) {
early return

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:248: }
nit {}'s

[Tom Sepez, 2016-09-01 22:05:37]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 22:05:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:06:55]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/1912)

[Tom Sepez, 2016-09-01 22:26:31]

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_generalstate.cpp (right):

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:214:
FXSYS_strcpy((FX_CHAR*)m_BlendMode, "Normal");
On 2016/09/01 14:17:09, dsinclair wrote:
> static_cast

rewrote to use bytstrings

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:224: if (src.m_pTransferFunc &&
src.m_pTransferFunc->m_pPDFDoc) {
On 2016/09/01 14:17:09, dsinclair wrote:
> invert and early return?

Nah, but invert inner if.

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:235: if (m_pTransferFunc &&
m_pTransferFunc->m_pPDFDoc) {
On 2016/09/01 14:17:09, dsinclair wrote:
> early return
Same.

https://codereview.chromium.org/2302683002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_generalstate.cpp:248: }
On 2016/09/01 14:17:09, dsinclair wrote:
> nit {}'s

No longer exists.

[Tom Sepez, 2016-09-02 22:41:31]

Description was changed from

==========
Make CPDF_GeneralStateData private.

All interaction goes through the CPDF_GeneralState, which
manages the underlying storage transparently to the callers.
==========

to

==========
Make CPDF_GeneralStateData private.

All interaction goes through the CPDF_GeneralState, which
manages the underlying storage transparently to the callers.

Make StateData use a real string and a real matrix rather
than C-style arrays.
==========

[Tom Sepez, 2016-09-02 22:41:32]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-09-02 22:41:42]

Lei, the followup

[Tom Sepez, 2016-09-02 22:41:53]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:41:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-02 22:53:58]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:54:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 23:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 23:23:34]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-02 23:36:58]

lgtm

https://codereview.chromium.org/2302683002/diff/100001/core/fpdfapi/fpdf_page...
File core/fpdfapi/fpdf_page/include/cpdf_generalstate.h (right):

https://codereview.chromium.org/2302683002/diff/100001/core/fpdfapi/fpdf_page...
core/fpdfapi/fpdf_page/include/cpdf_generalstate.h:15: class CPDF_Object;
alphabetical order

[Tom Sepez, 2016-09-02 23:38:46]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-09-02 23:38:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2302683002/#ps120001
(title: "Alphabetical order")

[commit-bot: I haz the power, 2016-09-02 23:38:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-02 23:39:15]

https://codereview.chromium.org/2302683002/diff/100001/core/fpdfapi/fpdf_page...
File core/fpdfapi/fpdf_page/include/cpdf_generalstate.h (right):

https://codereview.chromium.org/2302683002/diff/100001/core/fpdfapi/fpdf_page...
core/fpdfapi/fpdf_page/include/cpdf_generalstate.h:15: class CPDF_Object;
On 2016/09/02 23:36:58, Lei Zhang wrote:
> alphabetical order

Done.

[commit-bot: I haz the power, 2016-09-02 23:53:12]

Description was changed from

==========
Make CPDF_GeneralStateData private.

All interaction goes through the CPDF_GeneralState, which
manages the underlying storage transparently to the callers.

Make StateData use a real string and a real matrix rather
than C-style arrays.
==========

to

==========
Make CPDF_GeneralStateData private.

All interaction goes through the CPDF_GeneralState, which
manages the underlying storage transparently to the callers.

Make StateData use a real string and a real matrix rather
than C-style arrays.

Committed:
https://pdfium.googlesource.com/pdfium/+/e106b50129d5b8ce50228c67d3b0170bc46c...
==========

[commit-bot: I haz the power, 2016-09-02 23:53:13]

Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/e106b50129d5b8ce50228c67d3b0170bc46c...