Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2302663002: Add more last resort fallback fonts in the vague hope that at least one can be loaded successfully. (Closed)

Created:
4 years, 3 months ago by Ilya Kulshin
Modified:
4 years, 3 months ago
Reviewers:
ananta, eae
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, pdr+graphicswatchlist_chromium.org, blink-reviews, f(malita), danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Latest round of telemetry indicates that at least some fraction of the crashes is due to bad font files. This change adds more last resort fallback fonts in the vague hope that at least one can be loaded successfully. BUG=561873 Committed: https://crrev.com/812b961cd6034d83cc24e8c2fc17ffa0ff80f953 Cr-Commit-Position: refs/heads/master@{#417116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Ilya Kulshin
ptal ananta@ - dwrite_font_proxy_message_filter_win.cc eae@ - FontCacheSkia.cpp
4 years, 3 months ago (2016-09-01 01:11:25 UTC) #5
Ilya Kulshin
ptal ananta@ - dwrite_font_proxy_message_filter_win.cc eae@ - FontCacheSkia.cpp
4 years, 3 months ago (2016-09-01 19:11:08 UTC) #9
eae
LGTM Lets hope this helps at last some!
4 years, 3 months ago (2016-09-05 20:56:32 UTC) #10
ananta
lgtm
4 years, 3 months ago (2016-09-07 21:24:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302663002/1
4 years, 3 months ago (2016-09-07 21:29:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 23:34:34 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 23:36:20 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/812b961cd6034d83cc24e8c2fc17ffa0ff80f953
Cr-Commit-Position: refs/heads/master@{#417116}

Powered by Google App Engine
This is Rietveld 408576698