Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2302643003:
Add error_details when the QuicCryptoServerConfig fails to get crypto proof. (Closed)
DescriptionAdd error_details when the QuicCryptoServerConfig fails to get crypto proof.
When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail.
This CL add an error_details for this case.
Related CL:https://codereview.chromium.org/2324833004/
Committed: https://crrev.com/0d430e2c89055212adff1d7ad3e20dbd2bf24aa9
Cr-Commit-Position: refs/heads/master@{#427413}
Patch Set 1 #Patch Set 2 : Merge. #Messages
Total messages: 24 (17 generated)
The CQ bit was checked by zhihuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. ========== to ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related WebRTC CL:https://codereview.webrtc.org/2287723003/ ==========
zhihuang@chromium.org changed reviewers: + gavinp@chromium.org
Hi, I have a change on this part. Please take a look. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related WebRTC CL:https://codereview.webrtc.org/2287723003/ ========== to ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related CL:https://codereview.chromium.org/2324833004/ ==========
The CQ bit was checked by gavinp@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by zhihuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zhihuang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org Link to the patchset: https://codereview.chromium.org/2302643003/#ps20001 (title: "Merge.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related CL:https://codereview.chromium.org/2324833004/ ========== to ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related CL:https://codereview.chromium.org/2324833004/ ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related CL:https://codereview.chromium.org/2324833004/ ========== to ========== Add error_details when the QuicCryptoServerConfig fails to get crypto proof. When building the QUIC code inside WebRTC, there is such a case that proof source failed to get proof and QuicCryptoServerConfig will return QUIC_HANDSHAKE_FAILED without error_details. This will cause error when calling CloseConnectionWithDetail. This CL add an error_details for this case. Related CL:https://codereview.chromium.org/2324833004/ Committed: https://crrev.com/0d430e2c89055212adff1d7ad3e20dbd2bf24aa9 Cr-Commit-Position: refs/heads/master@{#427413} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0d430e2c89055212adff1d7ad3e20dbd2bf24aa9 Cr-Commit-Position: refs/heads/master@{#427413} |
