Add support for color input datalist on Android

ui/android/java/res/layout/color_picker_dialog_content.xml

Index: ui/android/java/res/layout/color_picker_dialog_content.xml
diff --git a/ui/android/java/res/layout/color_picker_dialog_content.xml b/ui/android/java/res/layout/color_picker_dialog_content.xml
index 8aa4dbaeffd0dc88f6c72ec0169aa02da10c7422..9d49a0e1c132fbf3c3900d22d78577738ea84370 100644
--- a/ui/android/java/res/layout/color_picker_dialog_content.xml
+++ b/ui/android/java/res/layout/color_picker_dialog_content.xml
@@ -4,53 +4,50 @@
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file.
 -->
-<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="wrap_content"
+    android:orientation="vertical"
+    android:padding="15dp">
 
-    <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    <ScrollView
         android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:orientation="vertical"
-        android:padding="15dp">
+        android:layout_height="wrap_content">

[newt (away), 2013/10/15 18:00:15]

Repeating this so it doesn't get lost: what does the advanced picker look like
on a small screen in landscape after
changing the layout_height to wrap_content? Do things look OK, or does the
dialog go off the edge of the screen?

You could test this by increasing the side of the advanced color picker (make
the rows tall, or the font big, etc).

[keishi, 2013/10/16 04:47:23]

Great idea. I tested this and it worked properly. The scroll view was as tall as
it could be and didn't go off the edge.

[newt (away), 2013/10/22 04:04:48]

Great. Thanks for checking.

 
         <org.chromium.ui.ColorPickerAdvanced
             android:id="@+id/color_picker_advanced"
             android:layout_width="match_parent"
             android:layout_height="wrap_content" />
+    </ScrollView>
 
-        <FrameLayout
-            android:id="@+id/color_picker_simple_border"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:background="@drawable/color_picker_border"
-            android:paddingStart="1px"
-            android:paddingEnd="1px"
-            android:paddingTop="1px">
+    <org.chromium.ui.ColorPickerSimple
+        android:id="@+id/color_picker_simple"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:divider="@color/color_picker_border_color"
+        android:dividerHeight="1px"
+        android:paddingStart="1px"
+        android:paddingEnd="1px"
+        android:paddingTop="1px"
+        android:paddingBottom="1px"
+        android:layout_marginBottom="-1px"

[newt (away), 2013/10/15 18:00:15]

why add paddingBottom and negative marginBottom? seems like you could remove
both of these attributes. (if not, layout_marginBottom should be at the top
after layout_height)

[keishi, 2013/10/16 04:47:23]

Done.

+        android:background="@drawable/color_picker_border" />
 
-            <org.chromium.ui.ColorPickerSimple
-                android:id="@+id/color_picker_simple"
-                android:layout_width="match_parent"
-                android:layout_height="100dp"/>
-        </FrameLayout>
+    <FrameLayout
+        android:id="@+id/more_colors_button_border"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:background="@drawable/color_picker_border"
+        android:padding="1px">
 
-        <FrameLayout
-            android:id="@+id/more_colors_button_border"
+        <org.chromium.ui.ColorPickerMoreButton
+            android:id="@+id/more_colors_button"
+            style="?android:attr/buttonBarButtonStyle"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:layout_below="@+id/color_picker_simple_border"
-            android:background="@drawable/color_picker_border"
-            android:padding="1px">
-
-            <org.chromium.ui.ColorPickerMoreButton
-                android:id="@+id/more_colors_button"
-                style="?android:attr/buttonBarButtonStyle"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:minHeight="48dp"
-                android:textAppearance="?android:attr/textAppearanceSmall"
-                android:text="@string/color_picker_button_more" />
-        </FrameLayout>
-
-    </RelativeLayout>
-</ScrollView>
+            android:minHeight="48dp"
+            android:textAppearance="?android:attr/textAppearanceSmall"
+            android:text="@string/color_picker_button_more" />
+    </FrameLayout>
+</LinearLayout>