ui/android/java/res/layout/color_button.xml - Issue 23026006: Add support for color input datalist on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/layout/color_button.xml

Issue 23026006: Add support for color input datalist on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2013/08/26 20:23:20 copyright copyright
	2

	3 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2013/08/26 20:23:20 don't use a nested layout just to create a backgro don't use a nested layout just to create a background effect. layout groups are expensive to create and draw, and this layout will be inflated many times. you can use a single View with a ShapeDrawable or a LayerDrawable as a background instead. keishi 2013/08/29 03:40:47 Done. Show quoted text On 2013/08/26 20:23:20, newt wrote: > don't use a nested layout just to create a background effect. layout groups are > expensive to create and draw, and this layout will be inflated many times. you > can use a single View with a ShapeDrawable or a LayerDrawable as a background > instead. Done.
	4 android:background="@drawable/color_button_border"

	5 android:orientation="vertical"

	6 android:layout_width="wrap_content"

	7 android:layout_height="wrap_content"

	8 android:padding="1dp">

	9 <View android:id="@+id/color_button_swatch"

	10 android:background="#ff0000"
	newt (away) 2013/08/26 20:23:20 unused background attribute unused background attribute
	11 android:layout_width="48dp"

	12 android:layout_height="48dp" />

	13 </LinearLayout>

OLD	NEW