Add support for color input datalist on Android

content/public/common/color_suggestion.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_COMMON_COLOR_SUGGESTION_H_
+#define CONTENT_PUBLIC_COMMON_COLOR_SUGGESTION_H_
+
+#include <vector>

[jam, 2013/11/07 18:51:57]

nit: not needed

[keishi, 2013/11/13 10:48:12]

Done.

+
+#include "base/strings/string16.h"
+#include "content/common/content_export.h"
+#include "third_party/WebKit/public/web/WebColorSuggestion.h"
+#include "third_party/skia/include/core/SkColor.h"
+
+namespace content {
+
+// Container for information about datalist suggestion for the color input
+// control.
+struct CONTENT_EXPORT ColorSuggestion {
+

[jam, 2013/11/07 18:51:57]

nti: extra line

[keishi, 2013/11/13 10:48:12]

Done.

+  ColorSuggestion();
+  explicit ColorSuggestion(const WebKit::WebColorSuggestion& suggestion);

[jam, 2013/11/07 18:51:57]

can you inline both of these constructors and then we don't need the .cc file?

[keishi, 2013/11/13 10:48:12]

I tried to do this but couldn't. When I had to change the include statements in
WebColorSuggestion.h to absolute paths, I needed to add blink as a dependency to
a bunch of targets. I had to move the #include for WebColorSuggestion.h to the
cc file so I only have to add the dependency to blink to content_common.gypi

+
+  SkColor color;
+  base::string16 label;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_COMMON_COLOR_SUGGESTION_H_