ui/android/java/res/drawable/color_button_background.xml - Issue 23026006: Add support for color input datalist on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/drawable/color_button_background.xml

Issue 23026006: Add support for color input datalist on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « content/renderer/renderer_webcolorchooser_impl.cc ('k') | ui/android/java/res/drawable/color_picker_border.xml » ('j') | ui/android/java/res/layout/color_picker_dialog_content.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2013 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">
	newt (away) 2013/10/15 18:00:15 this is currently a bit broken in rtl languages. s this is currently a bit broken in rtl languages. suggestion: 1. Replace this file with: <shape android:shape="rectangle"> <stroke android:width="1px" android:color="@color/color_picker_background_color" /> <solid android:color="#FF0000"/> </shape> 2. Draw the color_picker_border_color as the background of the LinearLayout containing each row of color buttons: In ColorSuggestionListAdapter, for each LinearLayout you create, set the background to color_picker_border_color, and for each button (except the last in each row), use ApiCompatibilityUtils.setMarginEnd() to give it a 1px end margin. keishi 2013/10/16 04:47:23 The number of suggestions might not be a multiple Show quoted text On 2013/10/15 18:00:15, newt wrote: > this is currently a bit broken in rtl languages. suggestion: > > 1. Replace this file with: > > <shape android:shape="rectangle"> > <stroke android:width="1px" > android:color="@color/color_picker_background_color" /> > <solid android:color="#FF0000"/> > </shape> > > 2. Draw the color_picker_border_color as the background of the LinearLayout > containing each row of color buttons: In ColorSuggestionListAdapter, for each > LinearLayout you create, set the background to color_picker_border_color, and > for each button (except the last in each row), use > ApiCompatibilityUtils.setMarginEnd() to give it a 1px end margin. The number of suggestions might not be a multiple of COLORS_PER_ROW, so if we set the background to color_picker_border_color the left over space in the last row will be gray. I used a negative margin start to overlap the borders.
	9 <item

	10 android:top="0dp"

	11 android:right="0dp"

	12 android:bottom="0dp"

	13 android:left="0dp">

	14 <shape android:shape="rectangle">

	15 <solid android:color="@color/color_picker_border_color"/>

	16 </shape>

	17 </item>

	18 <item android:right="1px">

	19 <shape android:shape="rectangle">

	20 <solid android:color="@color/color_picker_background_color"/>

	21 </shape>

	22 </item>

	23 <item

	24 android:id="@+id/color_button_swatch"

	25 android:top="1px"

	26 android:right="2px"

	27 android:bottom="1px"

	28 android:left="1px">

	29 <shape android:shape="rectangle">

	30 <solid android:color="#FF0000"/>

	31 </shape>

	32 </item>

	33 </layer-list>

OLD	NEW