Add support for color input datalist on Android

ui/android/java/src/org/chromium/ui/ColorSuggestionListAdapter.java

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.ui;
+
+import android.content.Context;
+import android.graphics.drawable.GradientDrawable;
+import android.graphics.drawable.LayerDrawable;
+import android.graphics.drawable.StateListDrawable;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.BaseAdapter;
+import android.widget.GridView;
+
+import java.util.ArrayList;
+
+public class ColorSuggestionListAdapter extends BaseAdapter implements View.OnClickListener {

[newt (away), 2013/10/09 06:07:03]

javadoc for all public classes and methods (except @Override methods)

[keishi, 2013/10/15 16:44:02]

Done.

+    private Context mContext;
+    private ColorSuggestion[] mSuggestions;
+    private OnColorSuggestionClickListener mListener;
+
+    ColorSuggestionListAdapter(Context context, ColorSuggestion[] suggestions) {
+        super();

[newt (away), 2013/10/09 06:07:03]

BaseAdapter doesn't define a constructor, so this isn't technically needed

[keishi, 2013/10/15 16:44:02]

Done.

+        mContext = context;
+        mSuggestions = suggestions;
+    }
+
+    public void setOnColorSuggestionClickListener(OnColorSuggestionClickListener listener) {
+        mListener = listener;
+    }
+
+    private void setupColorButton(View button, int index) {

[newt (away), 2013/10/09 06:07:03]

"setup" -> "setUp"

[keishi, 2013/10/15 16:44:02]

Done.

+        if (index >= mSuggestions.length) {
+            button.setTag(new Integer(-1));

[newt (away), 2013/10/09 06:07:03]

I'd just set the tag to null

[keishi, 2013/10/15 16:44:02]

Done.

+            button.setEnabled(false);
+            button.setContentDescription(null);
+            button.setImportantForAccessibility(View.IMPORTANT_FOR_ACCESSIBILITY_NO);

[newt (away), 2013/10/09 06:07:03]

View.IMPORTANT_FOR_ACCESSIBILITY_NO was added in Android API level 16, and we
have to support back to level 14. I'd just remove this line. Instead:

    button.setVisibility(View.INVISIBLE)

(and you can remove calls to button.setEnabled())

[keishi, 2013/10/15 16:44:02]

Done.

+            return;
+        }
+        button.setTag(new Integer(index));

[newt (away), 2013/10/09 06:07:03]

why not just set the tag to the ColorSuggestion?

    button.setTag(mSuggestions[index]);

[keishi, 2013/10/15 16:44:02]

Done.

+        button.setEnabled(true);
+        ColorSuggestion suggestion = mSuggestions[index];
+        StateListDrawable background = (StateListDrawable) button.getBackground();
+        LayerDrawable layers = (LayerDrawable) background.getCurrent();
+        GradientDrawable swatch =
+                (GradientDrawable) layers.findDrawableByLayerId(R.id.color_button_swatch);
+        swatch.setColor(suggestion.mColor);
+        String description = suggestion.mLabel;
+        if (description.isEmpty()) {

[newt (away), 2013/10/09 06:07:03]

can you be sure that description is never null? if not, you can use
TextUtils.isEmpty(description)

[keishi, 2013/10/15 16:44:02]

Done.

+            description = String.format("#%06X", (0xFFFFFF & suggestion.mColor));
+        }
+        button.setContentDescription(description);
+        button.setImportantForAccessibility(View.IMPORTANT_FOR_ACCESSIBILITY_YES);
+        button.setOnClickListener(this);
+    }
+
+    @Override
+    public void onClick(View v) {
+        if (mListener == null)

[newt (away), 2013/10/09 06:07:03]

need curly braces for if-else in Java, unless it's a single line if statement:

    if (mListener == null) return;

[keishi, 2013/10/15 16:44:02]

Done.

+            return;
+        Integer index = (Integer) v.getTag();

[newt (away), 2013/10/09 06:07:03]

it's probably good to safeguard against null tags here

[keishi, 2013/10/15 16:44:02]

Done.

+        if (index < 0)
+            return;
+        mListener.onColorSuggestionClick(mSuggestions[index]);
+    }
+
+    @Override
+    public View getView(int position, View convertView, ViewGroup parent) {
+        View layout = convertView;
+        if (convertView == null) {

[newt (away), 2013/10/09 06:07:03]

Ideally, we'd be able to configure the number of colors in a row at runtime.

An idea: You could delete color_button_row.xml and create color_buttom.xml
describing a single color button. Then create a LinearLayout programmatically
here, and inflate and add N color buttons here.

If not, you should at least replace "4" throughout this file with a meaningful
constant like "COLORS_PER_ROW".

[keishi, 2013/10/15 16:44:02]

I tried color_buttom.xml but the attributes like layout_width and layout_height
were being ignored (couldn't figure out why), so I changed it to code.

+            LayoutInflater inflater =

[newt (away), 2013/10/09 06:07:03]

easier: LayoutInflater inflater = LayoutInflater.from(mContext);

[keishi, 2013/10/15 16:44:02]

Done.

+                    (LayoutInflater) mContext.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
+            layout = inflater.inflate(R.layout.color_button_row, null);
+        }
+        setupColorButton(layout.findViewById(R.id.color_button_1), position * 4);
+        setupColorButton(layout.findViewById(R.id.color_button_2), position * 4 + 1);
+        setupColorButton(layout.findViewById(R.id.color_button_3), position * 4 + 2);
+        setupColorButton(layout.findViewById(R.id.color_button_4), position * 4 + 3);
+        return layout;
+    }
+
+    @Override
+    public long getItemId(int position) {
+        return position;
+    }
+
+    @Override
+    public Object getItem(int position) {
+        return mSuggestions[position * 4];

[newt (away), 2013/10/09 06:07:03]

I'd prefer returning null here -- that makes it clear that we're not actually
using this

[keishi, 2013/10/15 16:44:02]

Done.

+    }
+
+    @Override
+    public int getCount() {
+        return (int) Math.ceil(mSuggestions.length / 4d);

[newt (away), 2013/10/09 06:07:03]

return (mSuggestions.length + 3) / 4;

[keishi, 2013/10/15 16:44:02]

Done.

+    }
+}