ui/android/java/res/drawable/color_button_background.xml - Issue 23026006: Add support for color input datalist on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/drawable/color_button_background.xml

Issue 23026006: Add support for color input datalist on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « ui/android/java/res/drawable-ldrtl/color_button_background.xml ('k') | ui/android/java/res/drawable/color_picker_border.xml » ('j') | ui/android/java/res/layout/color_button_row.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2013 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <selector xmlns:android="http://schemas.android.com/apk/res/android">

	9
	newt (away) 2013/10/09 06:07:03 remove stray empty lines. this should look cleaner remove stray empty lines. this should look cleaner. keishi 2013/10/15 16:44:02 Done. Show quoted text On 2013/10/09 06:07:03, newt wrote: > remove stray empty lines. this should look cleaner. Done.
	10 <item android:state_enabled="false">
	newt (away) 2013/10/09 06:07:03 don't need a selector or this first item. as per t don't need a selector or this first item. as per the comment in ColorSuggestionListAdapter, you should just hide the color button instead of disabling it keishi 2013/10/15 16:44:02 Done. Show quoted text On 2013/10/09 06:07:03, newt wrote: > don't need a selector or this first item. as per the comment in > ColorSuggestionListAdapter, you should just hide the color button instead of > disabling it Done.
	11

	12 <shape>

	13

	14 <solid android:color="#FFFFFF" />

	15 </shape>

	16 </item>

	17 <item>

	18

	19 <layer-list>

	20

	21 <item android:top="0dp"
	newt (away) 2013/10/09 06:07:03 top, right, left, and bottom are optional. you can top, right, left, and bottom are optional. you can leave them out when they're just 0dp keishi 2013/10/15 16:44:02 Done. Show quoted text On 2013/10/09 06:07:03, newt wrote: > top, right, left, and bottom are optional. you can leave them out when they're > just 0dp Done.
	22 android:right="0dp"

	23 android:bottom="0dp"

	24 android:left="0dp">

	25

	26 <shape android:shape="rectangle">

	27

	28 <solid android:color="@color/color_picker_border_color"/>

	29 </shape>

	30 </item>

	31

	32 <item android:top="0dp"

	33 android:right="1dp"

	34 android:bottom="0dp"

	35 android:left="0dp">

	36

	37 <shape android:shape="rectangle">

	38

	39 <solid android:color="@color/color_picker_background_color"/ >

	40 </shape>

	41 </item>

	42

	43 <item android:id="@+id/color_button_swatch"
	newt (away) 2013/10/09 06:07:03 put each attribute on its own line: <item put each attribute on its own line: <item android:id="..." android:top="..." ... keishi 2013/10/15 16:44:02 Done. Show quoted text On 2013/10/09 06:07:03, newt wrote: > put each attribute on its own line: > > <item > android:id="..." > android:top="..." > ... Done.
	44 android:top="1dp"

	45 android:right="2dp"

	46 android:bottom="1dp"

	47 android:left="1dp">

	48

	49 <shape android:shape="rectangle">

	50

	51 <solid android:color="#FF0000"/>

	52 </shape>

	53 </item>

	54 </layer-list>

	55 </item>

	56 </selector>

OLD	NEW