Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2302593003: Change status bubble rendering at hidpi and when there is no client edge (Closed)

Created:
4 years, 3 months ago by Bret
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Change status bubble rendering at hidpi and when there is no client edge The recently removed client edge on Windows 10 made the status bubble overlap the window edge. This patch clips out the bubble border when the bubble is docked, and leaves it unchanged when it's floating. Also made the border always 1 pixel even at hidpi to make it look more consistent with the material UI. BUG=636479 Review-Url: https://codereview.chromium.org/2247563002 Cr-Commit-Position: refs/heads/master@{#415216} (cherry picked from commit e5a8ba6722632879cfa09ef0e7f8d7f4a99c5d4e) Committed: https://chromium.googlesource.com/chromium/src/+/8a691201c820fb62c5b9aef708cc263712559875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -75 lines) Patch
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 3 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 15 chunks +121 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
4 years, 3 months ago (2016-08-31 21:44:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a691201c820fb62c5b9aef708cc263712559875.

Powered by Google App Engine
This is Rietveld 408576698