Check for non-null assignment when checking casts

Check for non-null assignment when checking casts

The correct behaviour is to check for non-null assignment every time we
check for downcasts, so I moved the invocation.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/7ee54976be3d8772c9de22908e22c107bb35048d

[stanm, 2016-09-01 01:23:18]

stanm@google.com changed reviewers:
+ jmesserly@google.com

[stanm, 2016-09-01 01:23:18]

Ran test/test_all.dart and the number of failures/errors didn't change w.r.t.
previous commit (7/1).

[Jennifer Messerly, 2016-09-01 01:28:54]

On 2016/09/01 01:23:18, stanm wrote:
> Ran test/test_all.dart and the number of failures/errors didn't change w.r.t.
> previous commit (7/1).

lgtm. if you want to add a test, it looks like something with compound
assignment or for each might do the trick.

(I'd have to see what those methods are using _checkDowncast for to see what
might trigger it)

[Jennifer Messerly, 2016-09-01 01:28:55]

On 2016/09/01 01:23:18, stanm wrote:
> Ran test/test_all.dart and the number of failures/errors didn't change w.r.t.
> previous commit (7/1).

lgtm. if you want to add a test, it looks like something with compound
assignment or for each might do the trick.

(I'd have to see what those methods are using _checkDowncast for to see what
might trigger it)

[stanm, 2016-09-01 20:37:08]

Added tests, but cannot make compound statement have an INVALID_ASSIGNMENT
error. Any suggestions?

[Jennifer Messerly, 2016-09-01 20:39:19]

LGTM. Yeah compound assignment might need another fix before they're exposed.

[stanm, 2016-09-01 22:25:32]

Description was changed from

==========
Check for non-null assignment when checking casts

The correct behaviour is to check for non-null assignment every time we
check for downcasts, so I moved the invocation.

BUG=
==========

to

==========
Check for non-null assignment when checking casts

The correct behaviour is to check for non-null assignment every time we
check for downcasts, so I moved the invocation.

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7ee54976be3d8772c9de22908e22c107bb35048d
==========

[stanm, 2016-09-01 22:25:33]

Committed patchset #2 (id:20001) manually as
7ee54976be3d8772c9de22908e22c107bb35048d (presubmit successful).