Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2302573002: Revert of Increase maximum size of the HPACK decoder dynamic table to 64 kB. (Closed)

Created:
4 years, 3 months ago by mdjones
Modified:
4 years, 3 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Increase maximum size of the HPACK decoder dynamic table to 64 kB. (patchset #1 id:1 of https://codereview.chromium.org/2300683002/ ) Reason for revert: Suspected patch causing Android Cronet Builder and other bots to fail BidirectionalStreamTest#testSimpleGet. Will re-land if not. Original issue's description: > Increase maximum size of the HPACK decoder dynamic table to 64 kB. > > * Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on > each HTTP/2 connection. > * Immediately notify HpackDecoder about the change so that it allows the encoder > to update the dynamic table size up to this limit. It is safe to do so before > receiving the SETTINGS ACK, because the new limit is larger than the default 4 > kB. In fact, a server following RFC 7540 Section 6.5.3 word-by-word might > already use the larger limit before sending an ACK. > > BUG=642784 > > Committed: https://crrev.com/30537e17941018ecffe781c009b39c7a8c4c8f30 > Cr-Commit-Position: refs/heads/master@{#415718} TBR=rch@chromium.org,bnc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642784 Committed: https://crrev.com/d9ba3be0a5057b52aa35756a3fe3156301890097 Cr-Commit-Position: refs/heads/master@{#415735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M net/spdy/buffered_spdy_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/hpack/hpack_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdjones
Created Revert of Increase maximum size of the HPACK decoder dynamic table to 64 kB.
4 years, 3 months ago (2016-08-31 20:10:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302573002/1
4 years, 3 months ago (2016-08-31 20:11:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:12:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9ba3be0a5057b52aa35756a3fe3156301890097 Cr-Commit-Position: refs/heads/master@{#415735}
4 years, 3 months ago (2016-08-31 20:15:21 UTC) #6
Bence
4 years, 3 months ago (2016-09-01 13:28:03 UTC) #7
Message was sent while issue was closed.
LGTM.  Thank you for reverting.  I'm working on a fix.

Powered by Google App Engine
This is Rietveld 408576698