Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2302553002: Fix up presubmit for SAN GCC->Clang fix. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
We should eventually land this too once we rename the bots.
4 years, 3 months ago (2016-08-31 19:17:57 UTC) #3
borenet
LGTM
4 years, 3 months ago (2016-08-31 19:21:31 UTC) #4
mtklein_C
Just gonna land this now so I don't forget to. The odds of someone other ...
4 years, 3 months ago (2016-08-31 19:22:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302553002/1
4 years, 3 months ago (2016-08-31 19:22:42 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:43:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/04fff6373eac91ca71ec6997d69c444d30ae1f38

Powered by Google App Engine
This is Rietveld 408576698