Changes GpuServiceInternal from StrongBinding to Binding

Changes GpuServiceInternal from Binding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. By converting to Binding when the pipe is closed GpuServiceInternal is not deleted.

BUG=none
TEST=none
R=sadrul@chromium.org

Committed: https://crrev.com/b36c0cb25026b014ab7e9aded3382e41b8a0f4cd
Cr-Commit-Position: refs/heads/master@{#415763}

[Fady Samuel, 2016-08-31 18:17:49]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-08-31 18:17:50]

I think not lgtm.

GpuServiceInternal has only one client, the window server.

[sadrul, 2016-08-31 18:53:15]

Yeah, I ran into StrongBinding<> causing issues last night, and changed to
mojo::Binding instead (https://codereview.chromium.org/2289553002/). That CL
still needs more work though. This piece can land independently.

https://codereview.chromium.org/2302523002/diff/1/services/ui/gpu/gpu_service...
File services/ui/gpu/gpu_service_internal.h (right):

https://codereview.chromium.org/2302523002/diff/1/services/ui/gpu/gpu_service...
services/ui/gpu/gpu_service_internal.h:156:
mojo::BindingSet<mojom::GpuServiceInternal> bindings_;
Should be just mojo::Binding<>

[sky, 2016-08-31 19:09:51]

Description was changed from

==========
Changes GpuServiceInternal from StrongBinding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. I believe we want
GpuServiceInternal to service more than one client, so BindingSet
seems like the appropriate fit.

BUG=none
TEST=none
R=sadrul@chromium.org
==========

to

==========
Changes GpuServiceInternal from Binding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. By converting to Binding when the pipe
is closed GpuServiceInternal is not deleted.

BUG=none
TEST=none
R=sadrul@chromium.org
==========

[sky, 2016-08-31 19:10:04]

Converted to Binding (and updated description). Take another look?

[Fady Samuel, 2016-08-31 19:10:48]

lgtm if sadrul is happy

[sky, 2016-08-31 19:11:29]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 19:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-31 19:12:32]

lgtm

https://codereview.chromium.org/2302523002/diff/20001/services/ui/gpu/gpu_ser...
File services/ui/gpu/gpu_service_internal.cc (right):

https://codereview.chromium.org/2302523002/diff/20001/services/ui/gpu/gpu_ser...
services/ui/gpu/gpu_service_internal.cc:66: binding_.Close();
I seem to remember someone mentioning explicit Close() is no longer needed for a
Bind().

[sky, 2016-08-31 19:34:28]

On 2016/08/31 19:12:32, sadrul wrote:
> lgtm
> 
>
https://codereview.chromium.org/2302523002/diff/20001/services/ui/gpu/gpu_ser...
> File services/ui/gpu/gpu_service_internal.cc (right):
> 
>
https://codereview.chromium.org/2302523002/diff/20001/services/ui/gpu/gpu_ser...
> services/ui/gpu/gpu_service_internal.cc:66: binding_.Close();
> I seem to remember someone mentioning explicit Close() is no longer needed for
a
> Bind().

My understanding is you need to explicitly Close(). The one change I am aware of
is that previously Close() would DCHECK that binding was bound. That is no
longer the case.

[sky, 2016-08-31 19:34:41]

The CQ bit was unchecked by sky@chromium.org

[sky, 2016-08-31 19:34:45]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:35:47]

Description was changed from

==========
Changes GpuServiceInternal from Binding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. By converting to Binding when the pipe
is closed GpuServiceInternal is not deleted.

BUG=none
TEST=none
R=sadrul@chromium.org
==========

to

==========
Changes GpuServiceInternal from Binding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. By converting to Binding when the pipe
is closed GpuServiceInternal is not deleted.

BUG=none
TEST=none
R=sadrul@chromium.org
==========

[commit-bot: I haz the power, 2016-08-31 21:35:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 21:37:53]

Description was changed from

==========
Changes GpuServiceInternal from Binding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. By converting to Binding when the pipe
is closed GpuServiceInternal is not deleted.

BUG=none
TEST=none
R=sadrul@chromium.org
==========

to

==========
Changes GpuServiceInternal from Binding to BindingSet

StrongBinding means GpuServiceInternal is deleted when the pipe is
closed, defeating the singleton nature. By converting to Binding when the pipe
is closed GpuServiceInternal is not deleted.

BUG=none
TEST=none
R=sadrul@chromium.org

Committed: https://crrev.com/b36c0cb25026b014ab7e9aded3382e41b8a0f4cd
Cr-Commit-Position: refs/heads/master@{#415763}
==========

[commit-bot: I haz the power, 2016-08-31 21:37:54]

Patchset 2 (id:??) landed as
https://crrev.com/b36c0cb25026b014ab7e9aded3382e41b8a0f4cd
Cr-Commit-Position: refs/heads/master@{#415763}