Mark auxclick as stable

Mark auxclick as stable

BUG=625847
Committed: https://crrev.com/7be81ca9b22fe6abb5a96d200f77167cae987b5f
Cr-Commit-Position: refs/heads/master@{#417053}

[Navid Zolghadr, 2016-08-31 17:46:21]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:47:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-31 17:52:44]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-31 18:14:13]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:50:02]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2016-09-01 18:22:43]

ping

[dtapuska, 2016-09-01 18:53:53]

lgtm

[dtapuska, 2016-09-01 18:56:01]

On 2016/09/01 at 18:53:53, dtapuska wrote:
> lgtm

make sure you update the
https://cs.chromium.org/chromium/src/android_webview/tools/system_webview_she...

[Navid Zolghadr, 2016-09-01 19:44:23]

On 2016/09/01 18:56:01, dtapuska wrote:
> On 2016/09/01 at 18:53:53, dtapuska wrote:
> > lgtm
> 
> make sure you update the
>
https://cs.chromium.org/chromium/src/android_webview/tools/system_webview_she...

It wasn't obvious enough or similar enough to our
global-interface-listing-expected.txt that I can update it manually. The
sequence in there doesn't match with what we have here. Is that okay to land
this and this time if somebody complains we can find out how to fix it later
ourselves? or if you know anyone can you add him to the review so we can make
sure we do the right thing.

[dtapuska, 2016-09-01 19:54:18]

dtapuska@chromium.org changed reviewers:
+ timvolodine@chromium.org

[dtapuska, 2016-09-01 19:54:19]

Tim, do you have a buildbot Navid can run?

[Navid Zolghadr, 2016-09-06 14:26:54]

nzolghadr@chromium.org changed reviewers:
+ rbyers@google.com

[Navid Zolghadr, 2016-09-06 14:26:55]

rbyers@chromium.org: Please review changes in 

third_party/WebKit/LayoutTests/virtual/stable/fast/events/mouse-click-events-expected.txt

[Navid Zolghadr, 2016-09-07 14:37:17]

On 2016/09/06 14:26:55, Navid Zolghadr wrote:
> mailto:rbyers@chromium.org: Please review changes in 
> 
>
third_party/WebKit/LayoutTests/virtual/stable/fast/events/mouse-click-events-expected.txt

ping

[Rick Byers, 2016-09-07 18:13:10]

On 2016/09/07 14:37:17, Navid Zolghadr wrote:
> On 2016/09/06 14:26:55, Navid Zolghadr wrote:
> > mailto:rbyers@chromium.org: Please review changes in 
> > 
> >
>
third_party/WebKit/LayoutTests/virtual/stable/fast/events/mouse-click-events-expected.txt
> 
> ping

LGTM

Regarding the webview tests, if it's not obvious how to update those manually
then I think it's fine to just give Tim the heads-up that they'll break (as this
CL does) and land away.  He's used to updating the expectations after a blink
feature launch.  We've talked before about improving this but I don't think
there's been any progress.

[Navid Zolghadr, 2016-09-07 18:22:01]

On 2016/09/07 18:13:10, Rick Byers wrote:
> On 2016/09/07 14:37:17, Navid Zolghadr wrote:
> > On 2016/09/06 14:26:55, Navid Zolghadr wrote:
> > > mailto:rbyers@chromium.org: Please review changes in 
> > > 
> > >
> >
>
third_party/WebKit/LayoutTests/virtual/stable/fast/events/mouse-click-events-expected.txt
> > 
> > ping
> 
> LGTM
> 
> Regarding the webview tests, if it's not obvious how to update those manually
> then I think it's fine to just give Tim the heads-up that they'll break (as
this
> CL does) and land away.  He's used to updating the expectations after a blink
> feature launch.  We've talked before about improving this but I don't think
> there's been any progress.

Alright. Will do that then.

[Navid Zolghadr, 2016-09-07 18:22:08]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-09-07 18:22:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 18:25:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 18:25:43]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Navid Zolghadr, 2016-09-07 19:06:57]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:07:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-07 20:21:24]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-09-07 20:21:29]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-09-07 20:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2302513002/#ps60001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-09-07 20:22:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:44:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-07 21:47:28]

Description was changed from

==========
Mark auxclick as stable

BUG=625847
==========

to

==========
Mark auxclick as stable

BUG=625847

Committed: https://crrev.com/7be81ca9b22fe6abb5a96d200f77167cae987b5f
Cr-Commit-Position: refs/heads/master@{#417053}
==========

[commit-bot: I haz the power, 2016-09-07 21:47:29]

Patchset 4 (id:??) landed as
https://crrev.com/7be81ca9b22fe6abb5a96d200f77167cae987b5f
Cr-Commit-Position: refs/heads/master@{#417053}

[timvolodine, 2016-09-08 14:53:10]

On 2016/09/07 18:13:10, Rick Byers wrote:
> On 2016/09/07 14:37:17, Navid Zolghadr wrote:
> > On 2016/09/06 14:26:55, Navid Zolghadr wrote:
> > > mailto:rbyers@chromium.org: Please review changes in 
> > > 
> > >
> >
>
third_party/WebKit/LayoutTests/virtual/stable/fast/events/mouse-click-events-expected.txt
> > 
> > ping
> 
> LGTM
> 
> Regarding the webview tests, if it's not obvious how to update those manually
> then I think it's fine to just give Tim the heads-up that they'll break (as
this
> CL does) and land away.  He's used to updating the expectations after a blink
> feature launch.  We've talked before about improving this but I don't think
> there's been any progress.

Yes sorry for the delay. Usually people just update it manually if the number of
changes is limited. There is also an automatic script:
android_webview/tools/system_webview_shell/test/data/run_tests.sh which can be
run with the "rebaseline" argument. It may be a bit out of date though, I'll
need to recheck this.

Navid: thanks for the heads-up, will take into account if the bots do indeed
break.