chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html - Issue 2302483003: Pin keyboard improvements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2302483003: Pin keyboard improvements. (Closed)

Patch Set: Fixed patch set 1 errors. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out	1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out

2 what i18n to use for keypad, ie, does 1 ABC make	2 what i18n to use for keypad, ie, does 1 ABC make

3 sense in every scenario? -->	3 sense in every scenario? -->

4	4

5 <link rel="import" href="chrome://resources/cr_elements/icons.html">	5 <link rel="import" href="chrome://resources/cr_elements/icons.html">

6 <link rel="import" href="chrome://resources/html/i18n_behavior.html">	6 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

7 <link rel="import" href="chrome://resources/html/polymer.html">	7 <link rel="import" href="chrome://resources/html/polymer.html">

8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">	9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">	10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">

(...skipping 202 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
213 <inner-text>$i18n{pinKeyboard9}</inner-text>	213 <inner-text>$i18n{pinKeyboard9}</inner-text>

214 </paper-button>	214 </paper-button>

215 </div>	215 </div>

216 <div class="row keyboard bottom-row">	216 <div class="row keyboard bottom-row">

217 <div class="digit-button"></div>	217 <div class="digit-button"></div>

218 <paper-button class="digit-button" on-tap="onNumberTap_" value="0">	218 <paper-button class="digit-button" on-tap="onNumberTap_" value="0">

219 <inner-text>$i18n{pinKeyboard0}</inner-text>	219 <inner-text>$i18n{pinKeyboard0}</inner-text>

220 </paper-button>	220 </paper-button>

221 <paper-icon-button class="digit-button backspace-button"	221 <paper-icon-button class="digit-button backspace-button"

222 disabled="[[!hasInput_(value)]]"	222 disabled="[[!hasInput_(value)]]"

223 on-tap="onPinClear_" icon="pin-keyboard:backspace">	223 icon="pin-keyboard:backspace"

	224 on-mousedown="onBackspaceMouseDown_"

	225 on-mouseleave="onBackspaceMouseUpLeave_"

	226 on-mouseup="onBackspaceMouseUpLeave_">

224 </paper-icon-button>	227 </paper-icon-button>

225 </div>	228 </div>

226 </div>	229 </div>

227 </div>	230 </div>

228 </template>	231 </template>

229 <script src="pin_keyboard.js"></script>	232 <script src="pin_keyboard.js"></script>

230 </dom-module>	233 </dom-module>

OLD	NEW