Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: scripts/slave/goma_utils.py

Issue 2302453004: Add buildbot metadata to compiler_proxy log (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/goma_utils.py
diff --git a/scripts/slave/goma_utils.py b/scripts/slave/goma_utils.py
index a1c1253ec4c8adfbdf108a2969547cf7e00f59f2..595f2c2df0a72e1bdb8e478b3afc1cf50f82217d 100644
--- a/scripts/slave/goma_utils.py
+++ b/scripts/slave/goma_utils.py
@@ -115,6 +115,23 @@ def UploadToGomaLogGS(
def UploadGomaCompilerProxyInfo(override_gsutil=None):
"""Upload goma compiler_proxy.INFO to Google Storage."""
latest_subproc_info = GetLatestGomaCompilerProxySubprocInfo()
+
+ clobber = 0
+ if os.environ.get('BUILDBOT_CLOBBER'):
+ clobber = 1
+ metadata = {
+ 'master': os.environ.get('BUILDBOT_MASTERNAME', 'unknown'),
+ 'slave': os.environ.get('BUILDBOT_SLAVENAME', 'unknown'),
+ 'builder': os.environ.get('BUILDBOT_BUILDERNAME', 'unknown'),
+ 'clobber': clobber
+ 'os': chromium_utils.PlatformName(),
+ 'env': {},
tikuta 2016/09/01 09:12:54 Why don't you use os.environ.clone()?
shinyak 2016/09/01 09:25:38 There is no method clone() in os.environ. json.dum
+ }
ukai 2016/09/02 05:06:31 sucproc info name?
+ for k, v in os.environ.iteritems():
+ metadata['env'][k] = v
+
+ text_to_append = '# end of compiler proxy log\n' + json.dumps(metadata)
+
if latest_subproc_info:
UploadToGomaLogGS(latest_subproc_info,
os.path.basename(latest_subproc_info),
@@ -129,6 +146,7 @@ def UploadGomaCompilerProxyInfo(override_gsutil=None):
# we might be able to upload it as-is.
log_path = UploadToGomaLogGS(
latest_info, os.path.basename(latest_info),
+ text_to_append=text_to_append,
override_gsutil=override_gsutil)
viewer_url = ('http://chromium-build-stats.appspot.com/compiler_proxy_log/'
+ log_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698