Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2302453002: ChromeOS: Fix "continue OOBE on restart" screen size calculation. (Closed)

Created:
4 years, 3 months ago by Alexander Alekseev
Modified:
4 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Fix "continue OOBE on restart" screen size calculation. This CL fixes sizes and styles of polymer-based OOBE after chrome restart. BUG=604119 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/26ece4c3730b0800d6db484a421289fa03bc2288 Cr-Commit-Position: refs/heads/master@{#416150}

Patch Set 1 #

Patch Set 2 : Bugfix #

Total comments: 6

Patch Set 3 : Update after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -31 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.js View 1 2 3 chunks +14 lines, -22 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_eula.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula.js View 1 2 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_network.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_network.js View 1 2 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Alexander Alekseev
Before this CL flags to enable Material Design OOBE were set in reloadContent OOBE method, ...
4 years, 3 months ago (2016-08-31 12:14:01 UTC) #5
achuithb
https://codereview.chromium.org/2302453002/diff/20001/chrome/browser/resources/chromeos/login/oobe.js File chrome/browser/resources/chromeos/login/oobe.js (right): https://codereview.chromium.org/2302453002/diff/20001/chrome/browser/resources/chromeos/login/oobe.js#newcode311 chrome/browser/resources/chromeos/login/oobe.js:311: // ---------- MD OOBE screen Do you still need ...
4 years, 3 months ago (2016-09-01 22:47:20 UTC) #6
achuithb
lgtm
4 years, 3 months ago (2016-09-01 22:47:39 UTC) #8
Alexander Alekseev
https://codereview.chromium.org/2302453002/diff/20001/chrome/browser/resources/chromeos/login/oobe.js File chrome/browser/resources/chromeos/login/oobe.js (right): https://codereview.chromium.org/2302453002/diff/20001/chrome/browser/resources/chromeos/login/oobe.js#newcode311 chrome/browser/resources/chromeos/login/oobe.js:311: // ---------- MD OOBE screen On 2016/09/01 22:47:20, achuithb ...
4 years, 3 months ago (2016-09-01 23:01:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302453002/40001
4 years, 3 months ago (2016-09-01 23:02:13 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 01:07:46 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 01:09:34 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/26ece4c3730b0800d6db484a421289fa03bc2288
Cr-Commit-Position: refs/heads/master@{#416150}

Powered by Google App Engine
This is Rietveld 408576698